Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 #5985

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 #5985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf6e764
Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9
a-siva Aug 9, 2018
5576384
Address source format error.
a-siva Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DEPS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ vars = {
# Dart is: https://github.com/dart-lang/sdk/blob/master/DEPS.
# You can use //tools/dart/create_updated_flutter_deps.py to produce
# updated revision list of existing dependencies.
'dart_revision': 'eab492385c3f345cb2f44f3b702b0e30e4a9c107',
'dart_revision': '1be785ae2ddb1754a184cd638ab719e94d86b4e9',

'dart_args_tag': '1.4.4',
'dart_async_tag': '2.0.8',
Expand Down Expand Up @@ -73,7 +73,7 @@ vars = {
'dart_plugin_tag': 'f5b4b0e32d1406d62daccea030ba6457d14b1c47',
'dart_pool_tag': '1.3.6',
'dart_protobuf_tag': '0.9.0',
'dart_pub_rev': '58fe996eab8d54f28f5109c407ff0ab62fbd835d',
'dart_pub_rev': '5962908a66e814dd78f6856a4e5f792c6db65fbc',
'dart_pub_semver_tag': '1.4.2',
'dart_quiver_tag': '0.29.0+2',
'dart_resource_rev': '2.1.5',
Expand Down
3 changes: 2 additions & 1 deletion ci/licenses_golden/licenses_third_party
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Signature: e451900a1345f7d287e1032e5a26dac9
Signature: 350887638dbf5cdb4d0e1879ddb0cf33

UNUSED LICENSES:

Expand Down Expand Up @@ -5827,6 +5827,7 @@ FILE: ../../../third_party/dart/runtime/lib/stacktrace.dart
FILE: ../../../third_party/dart/runtime/lib/symbol_patch.dart
FILE: ../../../third_party/dart/runtime/lib/timer_impl.dart
FILE: ../../../third_party/dart/runtime/lib/typed_data.cc
FILE: ../../../third_party/dart/runtime/lib/typed_data_patch.dart
FILE: ../../../third_party/dart/runtime/lib/uri.cc
FILE: ../../../third_party/dart/runtime/lib/uri_patch.dart
FILE: ../../../third_party/dart/runtime/observatory/lib/src/app/application.dart
Expand Down
2 changes: 1 addition & 1 deletion lib/ui/plugins/callback_cache.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ Dart_Handle DartCallbackCache::LookupDartClosure(

Dart_Handle closure;
if (Dart_IsNull(cls_name)) {
closure = Dart_GetClosure(library, closure_name);
closure = Dart_GetField(library, closure_name);
} else {
Dart_Handle cls = Dart_GetClass(library, cls_name);
DART_CHECK_VALID(cls);
Expand Down
6 changes: 3 additions & 3 deletions runtime/dart_isolate.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,8 @@ bool DartIsolate::Run(const std::string& entrypoint_name) {

tonic::DartState::Scope scope(this);

Dart_Handle entrypoint = Dart_GetClosure(
Dart_RootLibrary(), tonic::ToDart(entrypoint_name.c_str()));
Dart_Handle entrypoint =
Dart_GetField(Dart_RootLibrary(), tonic::ToDart(entrypoint_name.c_str()));
if (tonic::LogIfError(entrypoint)) {
return false;
}
Expand Down Expand Up @@ -506,7 +506,7 @@ bool DartIsolate::RunFromLibrary(const std::string& library_name,
}

Dart_Handle entrypoint =
Dart_GetClosure(library, tonic::ToDart(entrypoint_name.c_str()));
Dart_GetField(library, tonic::ToDart(entrypoint_name.c_str()));
if (tonic::LogIfError(entrypoint)) {
return false;
}
Expand Down