Persist DartCallbackCache contents across launches #5947
Conversation
restored on engine startup
| @@ -44,7 +45,8 @@ void FlutterMain::Init(JNIEnv* env, | |||
| jclass clazz, | |||
| jobject context, | |||
| jobjectArray jargs, | |||
| jstring bundlePath) { | |||
| jstring bundlePath, | |||
| jstring appRootPath) { | |||
There was a problem hiding this comment.
Who has write access to appRootPath? Could application code accidentally clobber the callback cache?
There was a problem hiding this comment.
This parameter is only visible to the internals of FlutterMain.java which only sets it to the result of PathUtils.getFilesDir(applicationContext); so it shouldn't be possible for the application to clobber the cache unless it's really trying to (e.g., by deleting the cache file directly).
| @@ -229,7 +230,7 @@ public static void ensureInitializationComplete(Context applicationContext, Stri | |||
| } | |||
| } | |||
|
|
|||
| private static native void nativeInit(Context context, String[] args, String bundlePath); | |||
| private static native void nativeInit(Context context, String[] args, String bundlePath, String appRootPath); | |||
There was a problem hiding this comment.
Change appRootPath to something reflecting that this path is writable (e.g. "storagePath" or "writablePath"?)
imho appRootPath sounds like a path where the app's own assets would live, inviting confusion with bundlePath
| @@ -34,6 +56,7 @@ int64_t DartCallbackCache::GetCallbackHandle(const std::string& name, | |||
|
|
|||
| if (cache_.find(hash) == cache_.end()) { | |||
| cache_[hash] = {name, class_name, library_path}; | |||
| SaveCacheToDisk(); | |||
There was a problem hiding this comment.
What is the lifecycle of the cache file? Is the cache file or any of its entries ever deleted?
Would anything within the cache become stale if the application's code is updated but the cache is not purged?
There was a problem hiding this comment.
Currently the cache is persistent and entries aren't deleted, although we could verify all the callbacks in the cache actually exist when we restore and remove the stale entries.
b3e866e Call drawPath without clip if possible (flutter/engine#5952) 7e0bb3b Allow freezing a texture. (flutter/engine#5938) 3cbb5e2 Persist DartCallbackCache contents across launches (flutter/engine#5947) 953570a libtxt: truncate paragraph width to an integer in order to match Blink's behavior (flutter/engine#5962)
Updated DartCallbackCache to write callback cache to disk which is restored on engine startup