This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Manual roll dart to 470117150f34d712ee6d8c4558b3c656d973f656 #56915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aam
force-pushed
the
roll-dart-20241202-2003
branch
from
7423f3d to
4e06c2d
Compare
There was a problem hiding this comment.
Can we move //flutter/third_party/boringssl/src to //flutter/third_party/dart/third_party/boringssl/src or put a forwarding GN file in the secondary tree to avoid duplicating this?
There was a problem hiding this comment.
Not sure - I had to make changes to it : added cflags_c = [ "-std=c17" ]
There was a problem hiding this comment.
Oh, I misunderstood - you talked about src folder, not about BUILD.gn
There was a problem hiding this comment.
Talked offline, confirmed that you did mean to get rid of copy of BUILD.gn which we could do if we put cflags_c=["-std=c17"] into dart's BUILD.gn. Perhaps we could do it as a later refactoring.
Changes since last roll ``` 470117150f3 Version 3.7.0-208.0.dev 10867627709 CHANGELOG: move AOT invocation bits to the end of the 3.7 section 83863711d3b Migrate NotImportedCompletionPass. e01bbdfd1f4 Deprecate completions from plugins api. 2a2905228fb Add extension on Completer to simplify code. 05696d50ccf Migrate postfix_completion.dart, statement_completion.dart. ed49d04e2e0 [analysis_server] Extract some shared code from editableArguments to be used by editArgument c54255fe9db [element model] migrate `prefer_asserts_in_initializer_lists` eaf3912b5d6 [deps] rev core, ecosystem, glob, http_multi_server, lints, markdown, package_config, pool, protobuf, pub_semver, shelf, source_maps, source_span, stack_trace, stream_channel, string_scanner, sync_http, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, vector_math, watcher, web, web_socket_channel, webdriver, webkit_inspection_protocol, yaml, yaml_edit 11a11259724 Switch boringssl to the pre-generated GN source list. a635ccf2f57 [analysis_server] Only mark positional arguments as editable if they wouldn't require inserting additional values 619c8511aba [analysis_server] Add tests for formatter language version for legacy protocol a8f5e64a330 Roll Fuchsia Test Scripts from 6FgM4KTbxxmyYoiOs... to VilXq4eGH5A24wRWA... 623c574b817 [vm] Clean up few isolate fields. bfb507a3af9 Migrate utilities.dart 06caa3fa11e [DAS] Adds new import with show option 0197beaa8e0 [flow analysis] Remove _typeContains method. 56b6e5b9f60 Json codable no type assumption in custom fromJson e013a4c9bfa [analysis_server] Add some notes on how to use the CPU Profiler for the analysis server hosted by VS Code 0f723b3ef3c [vm] Fix build on gcc 14.2.0. ``` This is manual roll because dart_boringssl_gen_rev is no longer present in dart sdk DEPS has to be removed from flutter engine DEPS manually.
aam
force-pushed
the
roll-dart-20241202-2003
branch
from
4e06c2d to
b866958
Compare
rmacnak-google
approved these changes
Dec 3, 2024
itsjustkevin
added
the
autosubmit
zanderso
reviewed
Dec 4, 2024
| # Ignore everything by default, as these come from gclient/DEPS. | ||
| # We'll explicitly include the folders we want to track. | ||
| /* | ||
| /boringssl/src |
There was a problem hiding this comment.
This should probably come after the section that re-includes (!boringssl/ etc.), and have a comment that explains why it's needed.
There was a problem hiding this comment.
Ah, good point.
The intent to clean it up further - remove this /boringssl/src from this .gitignore.
The intent is to avoid copying boringssl/BUILD.gn, reuse third_party/dart/third_party/boringssl/BUILD.gn instead and check boringssl sources out into third_party/dart/third_party/boringssl/src. See b866958 that kind of attempted to do it - the attempt was not quite correct as we do need to add cflags_c = [ "-std=c17" ] to dart's third_party/dart/third_party/boringssl/BUILD.gn - inserting it via flutter/engine/third_party/boringssl/BUILD.gn doesn't work.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 4, 2024
…159805) flutter/engine@29d6640...1f7f37e 2024-12-04 [email protected] [Impeller] avoid heap allocation in RenderTarget object. (flutter/engine#56829) 2024-12-04 [email protected] Manual roll dart to 470117150f34d712ee6d8c4558b3c656d973f656 (flutter/engine#56915) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…/engine#56915) Roll dart to 470117150f34d712ee6d8c4558b3c656d973f656 Changes since last roll ``` 470117150f3 Version 3.7.0-208.0.dev 10867627709 CHANGELOG: move AOT invocation bits to the end of the 3.7 section 83863711d3b Migrate NotImportedCompletionPass. e01bbdfd1f4 Deprecate completions from plugins api. 2a2905228fb Add extension on Completer to simplify code. 05696d50ccf Migrate postfix_completion.dart, statement_completion.dart. ed49d04e2e0 [analysis_server] Extract some shared code from editableArguments to be used by editArgument c54255fe9db [element model] migrate `prefer_asserts_in_initializer_lists` eaf3912b5d6 [deps] rev core, ecosystem, glob, http_multi_server, lints, markdown, package_config, pool, protobuf, pub_semver, shelf, source_maps, source_span, stack_trace, stream_channel, string_scanner, sync_http, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, vector_math, watcher, web, web_socket_channel, webdriver, webkit_inspection_protocol, yaml, yaml_edit 11a11259724 Switch boringssl to the pre-generated GN source list. a635ccf2f57 [analysis_server] Only mark positional arguments as editable if they wouldn't require inserting additional values 619c8511aba [analysis_server] Add tests for formatter language version for legacy protocol a8f5e64a330 Roll Fuchsia Test Scripts from 6FgM4KTbxxmyYoiOs... to VilXq4eGH5A24wRWA... 623c574b817 [vm] Clean up few isolate fields. bfb507a3af9 Migrate utilities.dart 06caa3fa11e [DAS] Adds new import with show option 0197beaa8e0 [flow analysis] Remove _typeContains method. 56b6e5b9f60 Json codable no type assumption in custom fromJson e013a4c9bfa [analysis_server] Add some notes on how to use the CPU Profiler for the analysis server hosted by VS Code 0f723b3ef3c [vm] Fix build on gcc 14.2.0. ``` This is manual roll because dart_boringssl_gen_rev is no longer present in dart sdk DEPS has to be removed from flutter engine DEPS manually.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll dart to 470117150f34d712ee6d8c4558b3c656d973f656
Changes since last roll
This is manual roll because dart_boringssl_gen_rev is no longer present
in dart sdk DEPS has to be removed from flutter engine DEPS manually.