This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "[iOS] Full keyboard access scrolling (#56606)" #56842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
requested review from
cbracken and
chinmaygarde
as code owners
github-actions
bot
added
platform-ios
platform-android
platform-web
LongCatIsLooong
added
the
autosubmit
auto-submit
bot
deleted the
revert-56802-revert_7a8c1e8031fff0cc05776c54e08712a580fe0699
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 3, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 3, 2024
…159702) flutter/engine@05fdaa6...5001e2a 2024-12-02 [email protected] Roll Skia from ac934b9e9df9 to 3db026d62805 (2 revisions) (flutter/engine#56908) 2024-12-02 [email protected] Roll Dart SDK from 46630dbefbbd to c579d193341d (1 revision) (flutter/engine#56907) 2024-12-02 [email protected] Reland "[iOS] Full keyboard access scrolling (#56606)" (flutter/engine#56842) 2024-12-02 [email protected] Always check for errors when propagating task values. (flutter/engine#56856) 2024-12-02 [email protected] Roll Skia from 2c4ce1d953ba to ac934b9e9df9 (1 revision) (flutter/engine#56904) 2024-12-02 [email protected] Fix linux on vivante drivers. (flutter/engine#56862) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…r/engine#56842) Reverts flutter/engine#56802 flutter#159517 should address the engine roll failure. I'm not planning to land this until the coming Monday.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #56802
flutter/flutter#159517 should address the engine roll failure.
I'm not planning to land this until the coming Monday.