Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@selfisekai
Copy link
Contributor

@selfisekai selfisekai commented Nov 26, 2024

The wiki hasn't existed for a long time, and the URLs now require manually following through a click to the documents.

List which issues are fixed by this PR. You must list at least one issue.
closes flutter/flutter#159514

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jonahwilliams jonahwilliams self-requested a review December 2, 2024 18:49
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2024
@auto-submit auto-submit bot merged commit 1e562dd into flutter:main Dec 2, 2024
27 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 2, 2024
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 2, 2024
…159694)

flutter/engine@e0900f8...05fdaa6

2024-12-02 [email protected] Roll Skia from d7751d3d6ff4 to
2c4ce1d953ba (5 revisions) (flutter/engine#56901)
2024-12-02 [email protected] [ci] use env for format and support
arm64 hosts (flutter/engine#56268)
2024-12-02 [email protected] Replace outdated wiki URLs in pull
request template (flutter/engine#56824)
2024-12-02 [email protected] [impeller] makes
UniformBindData 15% faster and adds unit test (flutter/engine#56844)
2024-12-02 [email protected] Roll Skia from dd70c8e1c38f to
d7751d3d6ff4 (36 revisions) (flutter/engine#56898)
2024-12-02 [email protected] Roll Dart SDK from
5785058c9bb1 to 46630dbefbbd (12 revisions) (flutter/engine#56897)
2024-12-02 [email protected] switched reactor
to absl::flat_hash_map (flutter/engine#56845)
2024-12-02 [email protected] Sped up
SubpixelGlyph::Equal (flutter/engine#56851)
2024-12-02 [email protected] [Impeller] dont cache glyph layout
if atlas is invalid. (flutter/engine#56879)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…6824)

The wiki hasn't existed for a long time, and the URLs now require manually following through a click to the documents.

*List which issues are fixed by this PR. You must list at least one issue.*
closes flutter#159514

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wiki URLs in engine pull request template are outdated

3 participants