IWYU: add some missing includes failing with libstdc++13/14 #56822
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
So i think this change is harmless and I'm happy to accept it, but since we don't/won't test using that particular libstdc++ the odds this keeps working probably rounds down to 0.
chinmaygarde
added
the
autosubmit
…159574) flutter/engine@ba112ad...dd0ef5b 2024-11-27 [email protected] Roll Fuchsia Test Scripts from OA7UxNZkbxCRfr80A... to VilXq4eGH5A24wRWA... (flutter/engine#56846) 2024-11-27 [email protected] IWYU: add some missing includes failing with libstdc++13/14 (flutter/engine#56822) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…engine#56822) Fixes builds of engine with libstdc++13 and libstdc++14. *List which issues are fixed by this PR. You must list at least one issue.* closes flutter#159513 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
3 participants
Fixes builds of engine with libstdc++13 and libstdc++14.
List which issues are fixed by this PR. You must list at least one issue.
closes flutter/flutter#159513
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.