This repository was archived by the owner on Feb 25, 2025. It is now read-only.
iOS: Fix typo in fluttterViewController #56770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into this typo during a separate refactoring. Breaking it out to avoid an already large patch getting any bigger.
loic-sharma
approved these changes
Nov 23, 2024
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
Goodbye flutterViewContoller!
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 23, 2024
…159369) flutter/engine@f776c3a...19563e5 2024-11-23 [email protected] Roll Dart SDK from eb01a0430f72 to 202083b79ac5 (1 revision) (flutter/engine#56772) 2024-11-23 [email protected] Roll Skia from c3d9596a93f8 to 6a3f77189dde (1 revision) (flutter/engine#56771) 2024-11-23 [email protected] iOS: Fix typo in fluttterViewController (flutter/engine#56770) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Ran into this typo during a separate refactoring. Breaking it out to avoid an already large patch getting any bigger. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this typo during a separate refactoring. Breaking it out to avoid an already large patch getting any bigger.
Pre-launch Checklist
///).If you need hilp, consadder asking for avduice on the #hackers-new channel on Discord.