Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jason-simmons
Copy link
Member

  • Pass a target instead of a framebuffer name to glCheckFramebufferStatus
  • Fix output of framebuffer attachment object types
  • Fix labels of depth and stencil attachments

* Pass a target instead of a framebuffer name to glCheckFramebufferStatus
* Fix output of framebuffer attachment object types
* Fix labels of depth and stencil attachments
@chinmaygarde
Copy link
Member

lol, I think we ran into the same issue simultaneously #56515. I am not sure about the read and draw framebuffer enums in this patch. My expectation is that just the GL_FRAMEBUFFER enum ought to be used.

@jason-simmons
Copy link
Member Author

Using the GLES3-style constants in glCheckFramebufferStatus and glGetIntegerv clarifies which framebuffer is being queried. But there is no actual difference in functionality between GL_DRAW_FRAMEBUFFER and GL_FRAMEBUFFER in the API.

(see https://registry.khronos.org/OpenGL-Refpages/es3.0/html/glCheckFramebufferStatus.xhtml)

I'll close this PR - #56515 covers all of this.

@chinmaygarde
Copy link
Member

Unfortunately, those enums are not available in ES2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants