This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Copy gen_snapshots using python's shutil.copy, avoid links (#55830)" #56034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Oct 22, 2024
auto-submit
bot
deleted the
revert_6c4f05c42aad0ea109df7bcdf4e175caaafc8bd7
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2024
jonahwilliams
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 23, 2024
…157389) flutter/engine@2d3f0f4...50f6d98 2024-10-22 [email protected] [Impeller] refactor clip rendering. (flutter/engine#56030) 2024-10-22 [email protected] Fix macos xcprivacy manifest copy location (flutter/engine#56010) 2024-10-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Copy gen_snapshots using python's shutil.copy, avoid links (#55830)" (flutter/engine#56034) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
M97Chahboun
pushed a commit
to M97Chahboun/flutter
that referenced
this pull request
Oct 30, 2024
…lutter#157389) flutter/engine@2d3f0f4...50f6d98 2024-10-22 [email protected] [Impeller] refactor clip rendering. (flutter/engine#56030) 2024-10-22 [email protected] Fix macos xcprivacy manifest copy location (flutter/engine#56010) 2024-10-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Copy gen_snapshots using python's shutil.copy, avoid links (flutter#55830)" (flutter/engine#56034) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…lutter#55830)" (flutter/engine#56034) Reverts: flutter/engine#55830 Initiated by: chinmaygarde Reason for reverting: Incremental builds are broken. flutter#157367 Original PR Author: aam Reviewed By: {mraleph, cbracken} This change reverts the following previous change: Default implementation of copy does it via hardlink, which seems to be causing issues with Gatekeeper on mac. BUG=flutter#154437
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #55830
Initiated by: chinmaygarde
Reason for reverting: Incremental builds are broken. flutter/flutter#157367
Original PR Author: aam
Reviewed By: {mraleph, cbracken}
This change reverts the following previous change:
Default implementation of copy does it via hardlink, which seems to be causing issues with Gatekeeper on mac.
BUG=flutter/flutter#154437