This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move redispatch_event from FlKeyboardViewDelegate to FlKeyboardManager #55941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events can only be redispatched using gdk_event_put which is not dependent on the view. Ideally the tests would mock gdk_event_put, but I wasn't able to get it working so I've added fl_keyboard_manager_set_redispatch_handler for now.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 18, 2024
…157143) flutter/engine@09598f6...0bb6b1f 2024-10-18 [email protected] Move redispatch_event from FlKeyboardViewDelegate to FlKeyboardManager (flutter/engine#55941) 2024-10-18 [email protected] Remove FlKeyResponder and use the two responder classes directly. (flutter/engine#55925) 2024-10-17 [email protected] Reland "iOS: Migrate FlutterEngine to ARC" (flutter/engine#55937) 2024-10-17 [email protected] [Flutter GPU] Remove Command/VertexBuffer usage from Flutter GPU. (flutter/engine#55893) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
flutter/engine#55941) Events can only be redispatched using gdk_event_put which is not dependent on the view. Ideally the tests would mock gdk_event_put, but I wasn't able to get it working so I've added fl_keyboard_manager_set_redispatch_handler for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events can only be redispatched using gdk_event_put which is not dependent on the view.
Ideally the tests would mock gdk_event_put, but I wasn't able to get it working so I've added fl_keyboard_manager_set_redispatch_handler for now.