Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Oct 16, 2024

  • Enable support for WOFF2 fonts.
  • Add Brotli depndency (increases CK size by ~53KB compressed, including the Brotli dictionary).
  • Use split WOFF2 fonts for Emoji.
  • Remove the useColorEmoji runtime config flag.

Partially based off of #41282
Fixes flutter/flutter#119536
Contributes to flutter/flutter#153974 and opens the door for moving more fonts to WOFF2.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Oct 16, 2024
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #55908 at sha b4524a3

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 21, 2024
@auto-submit auto-submit bot merged commit 1252ac0 into flutter:main Oct 21, 2024
38 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 21, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 21, 2024
…157277)

flutter/engine@68f9225...1a8ef6e

2024-10-21 [email protected] Request another frame in ImageReaderSurfaceProducer.dequeueImage if more images are pending in the queue (flutter/engine#55944)
2024-10-21 [email protected] Roll Dart SDK from c8659684d34d to 10387c3fc6d4 (1 revision) (flutter/engine#55987)
2024-10-21 [email protected] [web] Support woff2 fonts (flutter/engine#55908)
2024-10-21 [email protected] Roll Fuchsia Linux SDK from PWz1ufnYNOGpgw-qg... to avSAUwQTf5xVGuZQU... (flutter/engine#55985)
2024-10-21 [email protected] Manual roll Dart SDK from a51df90298ca to c8659684d34d (4 revisions) (flutter/engine#55984)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from PWz1ufnYNOGp to avSAUwQTf5xV

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@mdebbar mdebbar deleted the woff2 branch October 22, 2024 15:39
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
- Enable support for WOFF2 fonts.
- Add Brotli depndency (increases CK size by ~53KB compressed, including the Brotli dictionary).
- Use split WOFF2 fonts for Emoji.
- Remove the `useColorEmoji` runtime config flag.

Partially based off of flutter/engine#41282
Fixes flutter#119536
Contributes to flutter#153974 and opens the door for moving more fonts to WOFF2.
@markdid
Copy link

markdid commented Jan 6, 2025

what's the standard way to get color emoji's in flutter web now? @mdebbar

@mdebbar
Copy link
Contributor Author

mdebbar commented Jan 6, 2025

what's the standard way to get color emoji's in flutter web now? @mdebbar

If you are on the master branch, color emojis should work out of the box. If you are on stable, you'll need to wait for the next stable release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine will affect goldens

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[web][3.7] Emojis are not properly rendered

3 participants