This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] libImpeller: Initialize the base paragraph style lazily. #55891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
added
e: impeller
e: libimpeller
Member
Author
|
@flar says @jason-simmons might also be a good reviewer. |
Member
Author
|
The distinction between the paragraph and text styles isn't super clear in txt. But I suppose it makes sense that you can't match text styles with different alignments and directions within a single text frame. This makes it so that the first opinion holds. |
|
@chinmaygarde Would there be any chance of adding a custom glyph layout system here instead of relying on flutter/flutter#132421 |
zanderso
approved these changes
Oct 16, 2024
Member
Author
|
That'd be a pretty involved undertaking. This API for external standalone Impeller users initially didn't even have typography but that was a pretty common ask and building a full-featured text stack was a heavy lift. So we are pretty much only exposing what we already have in |
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 16, 2024
…156931) flutter/engine@04d9894...5b468b7 2024-10-16 [email protected] Manual roll Dart SDK from 2bf0f2b8d391 to 7fce3544047c (4 revisions) (flutter/engine#55896) 2024-10-16 [email protected] Roll Fuchsia Linux SDK from T2Cq00sVabK2fCW9r... to OTfEfbaoT9c0HcprI... (flutter/engine#55894) 2024-10-16 [email protected] Remove obsolete fl_keyboard_view_delegate_get_messenger (flutter/engine#54857) 2024-10-16 [email protected] Manual roll Dart SDK from d916a5f69a48 to 2bf0f2b8d391 (24 revisions) (flutter/engine#55884) 2024-10-16 [email protected] [Impeller] libImpeller: Initialize the base paragraph style lazily. (flutter/engine#55891) 2024-10-16 [email protected] Split FlKeyboardManager out of FlKeyboardHandler (flutter/engine#55892) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from T2Cq00sVabK2 to OTfEfbaoT9c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…lutter/engine#55891) Thanks to the @lyceel for the failing test case. <img width="1136" alt="Screenshot 2024-10-15 at 4 01 27â�¯PM" src="https://github.com/user-attachments/assets/eeecba1d-eecb-4f29-878f-caf4c674a836">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the @lyceel for the failing test case.
