[Impeller] libImpeller: Fix missing exports on some paint methods. #55814
Conversation
cc @lyceel. I'll followup with a linker script to to verify this later.
chinmaygarde
added
e: impeller
e: libimpeller
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
chinmaygarde
added
the
autosubmit
|
auto label is removed for flutter/engine/55814, due to - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
chinmaygarde
added
the
autosubmit
…156609) flutter/engine@d13cbfb...bc3b180 2024-10-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Fuchsia] Use more high level fuchsia-gn-sdk templates (#55445)" (flutter/engine#55834) 2024-10-11 [email protected] [Impeller] libImpeller: Fix missing exports on some paint methods. (flutter/engine#55814) 2024-10-11 6844906[email protected] [fuchsia] Use the right versioned libs according to the target-api-level (flutter/engine#55786) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter/engine#55814) cc @lyceel. I'll followup with a linker script to to verify this later.
2 participants
cc @lyceel. I'll followup with a linker script to to verify this later.