This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Recognizegroup, and warn when we silently discard targets.
#55791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Oct 9, 2024
| @@ -1,3 +1,4 @@ | |||
| import 'package:collection/collection.dart'; | |||
Member
There was a problem hiding this comment.
This file needs a copyright header.
zanderso
reviewed
Oct 10, 2024
| // unneccesarily noisy, we can remove it or limit it to verbose mode. | ||
| if (allTargets.length < commandLineTargets.length) { | ||
| environment.logger.warning( | ||
| 'One or more targets specified did not match any build targets.', |
Member
There was a problem hiding this comment.
It could be helpful to report at least one of the ones that didn't match, but I guess if folks are typing these in, there won't be so many that reporting all the ones that didn't match would be too much.
Contributor
Author
There was a problem hiding this comment.
That seems reasonable and easy to do! Done.
zanderso
approved these changes
Oct 10, 2024
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 11, 2024
…156555) flutter/engine@3ce72a2...3f0e2fb 2024-10-10 [email protected] Roll Fuchsia Linux SDK from xGr5ZkxX3CajAY1xu... to 1OZ2rHDklRNSZRUrc... (flutter/engine#55807) 2024-10-10 [email protected] Recognize`group`, and warn when we silently discard targets. (flutter/engine#55791) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from xGr5ZkxX3Caj to 1OZ2rHDklRNS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…/engine#55791) Closes flutter#156260. Fixes the degenerate case where you specify an unrecognized target, and it falls back to rebuilding the entire engine as if you specified nothing. In addition, added recognition of `group`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#156260.
Fixes the degenerate case where you specify an unrecognized target, and it falls back to rebuilding the entire engine as if you specified nothing. In addition, added recognition of
group.