This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Zip and upload Xcode xcresults on scenario test failure #55093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Sep 10, 2024
| @implementation SpawnEngineTest | ||
|
|
||
| - (void)testSpawnEngineWorks { | ||
| XCTFail(); |
Member
Author
There was a problem hiding this comment.
Intentional failure to validate the xcresult upload in this PR.
Member
Author
There was a problem hiding this comment.
Woo:
However due to flutter/flutter#154956 (comment) the xcresult path is
/Users/m/Downloads/Volumes/Work/s/w/ir/cache/builder/src/out/ci/ios_debug_unopt_sim/scenario_app/Scenarios/ios_scenario_xcresult2Jzijm/ios_scenario.xcresult
And there are 3 xcresults in the Scenarios directory. I vote we land this anyway and investigate that separately since this change is an improvement since it actually uploads the xcresult.
matanlurey
approved these changes
Sep 11, 2024
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2024
jesswrd
pushed a commit
to jesswrd/engine
that referenced
this pull request
Sep 11, 2024
The `FLUTTER_ENGINE` has a `/` in it: `ci/ios_debug_unopt_sim`. ``` path.join(storePath, '$iosEngineVariant.zip'); ``` was resolving to `path_to_output/ci/ios_debug_unopt_sim.zip`. `path_to_output` existed, but the `ci` directory didn't: > zip error: Could not create output file (/Volumes/Work/s/w/ir/x/w/rc/flutter_logs_dir/ci/ios_debug_unopt_sim.zip) Change the output zip path to `path_to_output/ci_ios_debug_unopt_sim.zip` with an underscore instead. Fixes flutter/flutter#154956 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 11, 2024
…155046) flutter/engine@ade8ef2...ee5adf6 2024-09-11 [email protected] Zip and upload Xcode xcresults on scenario test failure (flutter/engine#55093) 2024-09-11 [email protected] [Impeller] hash less text stuff per frame for text rendering. (flutter/engine#55060) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FLUTTER_ENGINEhas a/in it:ci/ios_debug_unopt_sim.was resolving to
path_to_output/ci/ios_debug_unopt_sim.zip.path_to_outputexisted, but thecidirectory didn't:Change the output zip path to
path_to_output/ci_ios_debug_unopt_sim.zipwith an underscore instead.Fixes flutter/flutter#154956
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.