Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Sep 6, 2024

Reverts: #54983

Initiated by: zanderso

Reason for reverting: The roll to the framework is failing on the version of the synthetic _macros package: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8737528015332264641/+/u/flutter_config_--clear-features/stdout

Original PR Author: a-siva

Reviewed By: {zanderso}

This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/1a6246225b75..0f783bdb7a4d

Merging Version 3.6.0-217.0.dev

The change https://dart-review.googlesource.com/c/sdk/+/382385 moved some package locations and these had to be adjusted in the Flutter DEPS file.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Sep 6, 2024
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@zanderso zanderso closed this Sep 6, 2024
@zanderso zanderso deleted the revert_44fe215cae49b7338a1cdd577185f7db08abc3fe branch September 6, 2024 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants