This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Remove duplicate gn_configs #54855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please take a look, thank you. |
jrwang
approved these changes
Aug 29, 2024
Contributor
jrwang
left a comment
jrwang
left a comment
There was a problem hiding this comment.
LGTM assuming checks pass
Contributor
Author
|
Thank you, I think the ci.yaml check is very irrelevant to this change. I am fetching the latest baseline and retrying. |
chinmaygarde
approved these changes
Aug 29, 2024
jason-simmons
approved these changes
Aug 29, 2024
Member
|
Let me know if you want me to land this. Also, consider go/flutter-onboarding to become a contributor and make this self-service. |
Contributor
Author
|
Hey, Chinmay, I am a committer already :) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 29, 2024
…154367) flutter/engine@3075094...2ed08d7 2024-08-29 [email protected] Roll Skia from 1d16eab57a8e to 82e12bf2991a (6 revisions) (flutter/engine#54876) 2024-08-29 [email protected] Use fuchsia.scheduler.RoleManager protocol (flutter/engine#54587) 2024-08-29 6844906[email protected] [fuchsia] Remove duplicate gn_configs (flutter/engine#54855) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#154367) flutter/engine@3075094...2ed08d7 2024-08-29 [email protected] Roll Skia from 1d16eab57a8e to 82e12bf2991a (6 revisions) (flutter/engine#54876) 2024-08-29 [email protected] Use fuchsia.scheduler.RoleManager protocol (flutter/engine#54587) 2024-08-29 6844906[email protected] [fuchsia] Remove duplicate gn_configs (flutter/engine#54855) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change https://crrev.com/c/5823950 moved most of the gn_configs to
fuchsia-gn-sdk, and they are not needed to be repeated again in
the gn_configs.gni anymore
Bug: 359657446
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.