Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP] Ensure orchestrators aren't assigned to 32 core machines #54791

Merged
merged 2 commits into from
Aug 26, 2024
Merged

[CP] Ensure orchestrators aren't assigned to 32 core machines #54791

merged 2 commits into from
Aug 26, 2024

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Aug 26, 2024

This PR contains CPs of two changes:

  1. Move Fuchsia tests to a separate config file #54591 to avoid running Fuchsia tests on dart-internal, which was needed in order to avoid conflicts in
  2. Ensure orchestrators aren't assigned to 32 core machines #54754, which avoids using 32 core machines as orchestrators. (Instead they'll use the 8 core machines that are no longer used for the Fuchsia tests.)

@zanderso
Move Fuchsia tests to a separate config file (flutter#54591)
71d7a33 
Temporary workaround for flutter/flutter#152186.
@zanderso
Ensure orchestrators aren't assigned to 32 core machines (flutter#54754)
4620ad1 
flutter#54747 worked, so I'm going to
apply that change to all builders on main, and then we can CP it into
the release branches.

For flutter/flutter#152186
christopherfujino
christopherfujino approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2024
@christopherfujino
Copy link
Contributor

christopherfujino commented Aug 26, 2024

FYI @reidbaker the only observable outcome of this should be that the release builds run faster, but just mentioning you here in case some catastrophic happens like you merge a PR and no postubmit CI builds run or something :)

@auto-submit auto-submit bot merged commit cd2627a into flutter:flutter-3.24-candidate.0 Aug 26, 2024
@zanderso zanderso deleted the 3.24-8core-cp branch August 27, 2024 01:32
@zanderso
Copy link
Member Author

zanderso commented Aug 27, 2024

Before: 3.4 hours - https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Linux%20engine_release_builder/1001/overview
After: 1.2 hours - https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Linux%20engine_release_builder/1007/overview

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @christopherfujino