Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Ensure orchestrators aren't assigned to 32 core machines #54754

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Ensure orchestrators aren't assigned to 32 core machines #54754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 73 additions & 4 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,14 +217,17 @@ targets:
# Scheduler will fail to get the platform
drone_dimensions:
- os=Linux
dimensions:
# This is needed so that orchestrators that only spawn subbuilds are not
# assigned to the large 32 core workers when doing release builds.
# For more details see the issue
# at https://github.com/flutter/flutter/issues/152186.
cores: "8"

- name: Linux linux_fuchsia_tests
recipe: engine_v2/engine_v2
timeout: 90
properties:
# TODO(zanderso): Add this back when this issue is closed:
# https://github.com/flutter/flutter/issues/152186
# release_build: "true"
config_name: linux_fuchsia_tests
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
Expand Down Expand Up @@ -258,8 +261,16 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: linux_arm_host_engine
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
- os=Linux
dimensions:
# This is needed so that orchestrators that only spawn subbuilds are not
# assigned to the large 32 core workers when doing release builds.
# For more details see the issue
# at https://github.com/flutter/flutter/issues/152186.
cores: "8"

- name: Linux linux_host_engine
recipe: engine_v2/engine_v2
Expand All @@ -272,8 +283,16 @@ targets:
[
{"dependency": "goldctl", "version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"}
]
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
- os=Linux
dimensions:
# This is needed so that orchestrators that only spawn subbuilds are not
# assigned to the large 32 core workers when doing release builds.
# For more details see the issue
# at https://github.com/flutter/flutter/issues/152186.
cores: "8"

- name: Linux linux_host_desktop_engine
recipe: engine_v2/engine_v2
Expand All @@ -282,8 +301,16 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: linux_host_desktop_engine
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
- os=Linux
dimensions:
# This is needed so that orchestrators that only spawn subbuilds are not
# assigned to the large 32 core workers when doing release builds.
# For more details see the issue
# at https://github.com/flutter/flutter/issues/152186.
cores: "8"

- name: Linux linux_android_aot_engine
recipe: engine_v2/engine_v2
Expand All @@ -292,8 +319,16 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: linux_android_aot_engine
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
- os=Linux
dimensions:
# This is needed so that orchestrators that only spawn subbuilds are not
# assigned to the large 32 core workers when doing release builds.
# For more details see the issue
# at https://github.com/flutter/flutter/issues/152186.
cores: "8"

- name: Linux linux_android_debug_engine
recipe: engine_v2/engine_v2
Expand All @@ -302,8 +337,16 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: linux_android_debug_engine
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
- os=Linux
dimensions:
# This is needed so that orchestrators that only spawn subbuilds are not
# assigned to the large 32 core workers when doing release builds.
# For more details see the issue
# at https://github.com/flutter/flutter/issues/152186.
cores: "8"

- name: Linux linux_license
recipe: engine_v2/builder
Expand All @@ -319,8 +362,16 @@ targets:
properties:
release_build: "true"
config_name: linux_web_engine
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
- os=Linux
dimensions:
# This is needed so that orchestrators that only spawn subbuilds are not
# assigned to the large 32 core workers when doing release builds.
# For more details see the issue
# at https://github.com/flutter/flutter/issues/152186.
cores: "8"
runIf:
- DEPS
- .ci.yaml
Expand Down Expand Up @@ -378,8 +429,16 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: mac_android_aot_engine
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
- os=Linux
dimensions:
# This is needed so that orchestrators that only spawn subbuilds are not
# assigned to the large 32 core workers when doing release builds.
# For more details see the issue
# at https://github.com/flutter/flutter/issues/152186.
cores: "8"

- name: Mac mac_clang_tidy
recipe: engine_v2/engine_v2
Expand Down Expand Up @@ -417,12 +476,16 @@ targets:
{
"sdk_version": "15a240d"
}
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
- os=Mac-13|Mac-14

# Avoid using a Mac orchestrator to save ~5 minutes of Mac host time.
- name: Linux mac_clangd
Copy link
Contributor

@christopherfujino christopherfujino Aug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have cores: "8"?

Copy link
Member Author

@zanderso zanderso Aug 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't have release_build: true, so it won't run on dash-internal. Adding cores: "8" would be harmless here, but isn't necessary.

Copy link
Member Author

@zanderso zanderso Aug 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to add it everywhere or add more comments? Not sure what would be the most useful. (Actually, most useful would be finding a sensible way to assign to big vs. little machine without needing to reference the exact number of cores, but I suspect that's more than we want to tackle right now...)

Copy link
Contributor

@christopherfujino christopherfujino Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, this is good as is

recipe: engine_v2/engine_v2
# Avoid using a Mac orchestrator to save ~5 minutes of Mac host time.
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
- os=Linux
properties:
Expand All @@ -446,6 +509,8 @@ targets:
{
"sdk_version": "15a240d"
}
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
- os=Mac-13|Mac-14
- cpu=x86
Expand All @@ -465,6 +530,8 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: windows_android_aot_engine
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
- os=Windows

Expand All @@ -475,6 +542,8 @@ targets:
add_recipes_cq: "true"
release_build: "true"
config_name: windows_host_engine
# Do not remove(https://github.com/flutter/flutter/issues/144644)
# Scheduler will fail to get the platform
drone_dimensions:
- os=Windows

Expand Down