Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@reidbaker
Copy link
Contributor

Follow up from #54450 (comment)

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@reidbaker reidbaker marked this pull request as draft August 16, 2024 19:15
@reidbaker reidbaker requested review from eseidel and zanderso August 16, 2024 20:00
@reidbaker reidbaker marked this pull request as ready for review August 16, 2024 20:20
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 19, 2024
@auto-submit auto-submit bot merged commit bf538a0 into main Aug 19, 2024
@auto-submit auto-submit bot deleted the p54450-jdk-var branch August 19, 2024 15:33
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 19, 2024
…153713)

flutter/engine@e29b552...bf538a0

2024-08-19 [email protected] Set download_jdk variable (flutter/engine#54584)
2024-08-19 [email protected] Roll Skia from e49cd5f3cffb to d88bfe2939e8 (1 revision) (flutter/engine#54613)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#153713)

flutter/engine@e29b552...bf538a0

2024-08-19 [email protected] Set download_jdk variable (flutter/engine#54584)
2024-08-19 [email protected] Roll Skia from e49cd5f3cffb to d88bfe2939e8 (1 revision) (flutter/engine#54613)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit that referenced this pull request Sep 27, 2024
Recent [changes](#54584) affected our builder configs, but the script that generates those builder configs wasn't updated.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants