[Impeller] Statically check stage interfaces for precision mismatches. #54375

chinmaygarde · 2024-08-06T21:53:30Z

flutter-dashboard · 2024-08-06T21:53:33Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

chinmaygarde · 2024-08-06T21:54:58Z

This should trip on the bug @jonahwilliams just fixed. The matching doesn't work on the headers generated from Metal because the same semantics aren't applied.

chinmaygarde · 2024-08-06T22:32:21Z

Ok, I see the following failures. @jonahwilliams already fixed the fast gradient.

<impeller::PorterDuffBlendVertexShader, impeller::PorterDuffBlendFragmentShader>
<impeller::FastGradientVertexShader, impeller::FastGradientFragmentShader>
<impeller::TextureUvFillVertexShader, impeller::TiledTextureFillExternalFragmentShader>

Fixes flutter/flutter#147078

chinmaygarde · 2024-08-06T23:20:31Z

I fixed up the shaders with precision values that made sense to me. PTAL.

jonahwilliams

LGTM!

…mismatches. (flutter/engine#54375)

…152985) flutter/engine@206e86e...5a0fd5f 2024-08-07 [email protected] [Impeller] Statically check stage interfaces for precision mismatches. (flutter/engine#54375) 2024-08-07 [email protected] Roll Skia from f04ba9cd0e4b to 968a00456bc5 (4 revisions) (flutter/engine#54378) 2024-08-06 [email protected] Roll Dart SDK from dedfa3393296 to f5d136899082 (5 revisions) (flutter/engine#54376) 2024-08-06 [email protected] [Impeller] Reorder pipeline construction in content context. (flutter/engine#54373) 2024-08-06 [email protected] [iOS] clean ups to platform view controller (flutter/engine#54335) 2024-08-06 [email protected] [Impeller] ensure precision matches for buggy vulkan drivers. (flutter/engine#54372) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

gaaclarke · 2024-08-07T15:25:31Z

impeller/renderer/shader_stage_compatibility_checker.h

+              input_slot->offset != output_slot->offset ||
+              input_slot->relaxed_precision != output_slot->relaxed_precision) {


nice, thanks

…lutter#152985) flutter/engine@206e86e...5a0fd5f 2024-08-07 [email protected] [Impeller] Statically check stage interfaces for precision mismatches. (flutter/engine#54375) 2024-08-07 [email protected] Roll Skia from f04ba9cd0e4b to 968a00456bc5 (4 revisions) (flutter/engine#54378) 2024-08-06 [email protected] Roll Dart SDK from dedfa3393296 to f5d136899082 (5 revisions) (flutter/engine#54376) 2024-08-06 [email protected] [Impeller] Reorder pipeline construction in content context. (flutter/engine#54373) 2024-08-06 [email protected] [iOS] clean ups to platform view controller (flutter/engine#54335) 2024-08-06 [email protected] [Impeller] ensure precision matches for buggy vulkan drivers. (flutter/engine#54372) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…e no inputs or outputs. (#54406) Also removes the workarounds and updates the docstring to talk about the PowerVR hack. I came across this while fixing #54375. Fixes flutter/flutter#146852

…lutter#152985) flutter/engine@206e86e...5a0fd5f 2024-08-07 [email protected] [Impeller] Statically check stage interfaces for precision mismatches. (flutter/engine#54375) 2024-08-07 [email protected] Roll Skia from f04ba9cd0e4b to 968a00456bc5 (4 revisions) (flutter/engine#54378) 2024-08-06 [email protected] Roll Dart SDK from dedfa3393296 to f5d136899082 (5 revisions) (flutter/engine#54376) 2024-08-06 [email protected] [Impeller] Reorder pipeline construction in content context. (flutter/engine#54373) 2024-08-06 [email protected] [iOS] clean ups to platform view controller (flutter/engine#54335) 2024-08-06 [email protected] [Impeller] ensure precision matches for buggy vulkan drivers. (flutter/engine#54372) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added the e: impeller label Aug 6, 2024

chinmaygarde requested review from gaaclarke and jonahwilliams August 6, 2024 22:32

[Impeller] Statically check stage interfaces for precision mismatches.

f0d5268

Fixes flutter/flutter#147078

chinmaygarde force-pushed the ioslotmatching branch from 0329772 to f0d5268 Compare August 6, 2024 22:50

chinmaygarde added 2 commits August 6, 2024 16:01

PR

991ed59

PR

1bda8b9

jonahwilliams approved these changes Aug 6, 2024

View reviewed changes

malioc

78c7c82

chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

auto-submit bot merged commit 5a0fd5f into flutter:main Aug 7, 2024

engine-flutter-autoroll mentioned this pull request Aug 7, 2024

Roll Flutter Engine from 206e86ee8a40 to 5a0fd5fbecc6 (6 revisions) flutter/flutter#152980

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2024

5a0fd5fbe [Impeller] Statically check stage interfaces for precision …

378023b

…mismatches. (flutter/engine#54375)

engine-flutter-autoroll mentioned this pull request Aug 7, 2024

Roll Flutter Engine from 206e86ee8a40 to 5a0fd5fbecc6 (6 revisions) flutter/flutter#152985

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2024

5a0fd5fbe [Impeller] Statically check stage interfaces for precision …

ca3ef65

…mismatches. (flutter/engine#54375)

gaaclarke reviewed Aug 7, 2024

View reviewed changes

chinmaygarde deleted the ioslotmatching branch August 7, 2024 18:51

chinmaygarde mentioned this pull request Aug 7, 2024

[Impeller] Make stage compatibility checker work with stages that have no inputs or outputs. #54406

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] Statically check stage interfaces for precision mismatches. #54375

[Impeller] Statically check stage interfaces for precision mismatches. #54375

Uh oh!

chinmaygarde commented Aug 6, 2024

Uh oh!

flutter-dashboard bot commented Aug 6, 2024

Uh oh!

chinmaygarde commented Aug 6, 2024

Uh oh!

chinmaygarde commented Aug 6, 2024 •

edited

Loading

Uh oh!

chinmaygarde commented Aug 6, 2024

Uh oh!

jonahwilliams left a comment

Uh oh!

gaaclarke Aug 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		input_slot->offset != output_slot->offset \|\|
		input_slot->relaxed_precision != output_slot->relaxed_precision) {

[Impeller] Statically check stage interfaces for precision mismatches. #54375

[Impeller] Statically check stage interfaces for precision mismatches. #54375

Uh oh!

Conversation

chinmaygarde commented Aug 6, 2024

Uh oh!

flutter-dashboard bot commented Aug 6, 2024

Uh oh!

chinmaygarde commented Aug 6, 2024

Uh oh!

chinmaygarde commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chinmaygarde commented Aug 6, 2024

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

gaaclarke Aug 7, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chinmaygarde commented Aug 6, 2024 •

edited

Loading