Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[iOS][macOS] Eliminate use of bitcode_strip #54240

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[iOS][macOS] Eliminate use of bitcode_strip #54240

merged 1 commit into from
Jul 31, 2024

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Jul 31, 2024 •
edited
Loading

Our executables are no longer built with bitcode enabled and thus bitcode_strip -r SOURCE -o DEST is just copying the file in question to the output location.

Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details.

Issue: flutter/flutter#107884

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
[iOS][macOS] Eliminate use of bitcode_strip
62f4ab4 
Our executables are no longer built with bitcode enabled and thus
`bitcode_strip -r SOURCE -o DEST` is just copying the file in question
to the output location.

Use of Bitcode was eliminated in Flutter in 2022. See linked issue for
details.

Issue: flutter/flutter#107884
@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2024
@auto-submit auto-submit bot merged commit 59351b4 into flutter:main Jul 31, 2024
@cbracken cbracken deleted the no-bitcode_strip branch July 31, 2024 01:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
59351b437 [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine…
9b4acd3 
…#54240)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
59351b437 [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine…
be8de6f 
…#54240)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
59351b437 [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine…
3ad2bf9 
…#54240)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
59351b437 [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine…
dc2ce20 
…#54240)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
59351b437 [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine…
190f752 
…#54240)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
59351b437 [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine…
76eecc3 
…#54240)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
59351b437 [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine…
39ebea7 
…#54240)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
59351b437 [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine…
b97a63c 
…#54240)
@zanderso
Copy link
Member

Reason for revert: Looks like some issue with file permissions https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20plugin_test_macos/19179/overview

@zanderso zanderso added the revert Label used to revert changes in a closed and merged pull request. label Jul 31, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
59351b437 [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine…
3426145 
…#54240)
auto-submit bot pushed a commit that referenced this pull request Jul 31, 2024
Revert "[iOS][macOS] Eliminate use of bitcode_strip (#54240)"
6deed42 
This reverts commit 59351b4.
@auto-submit auto-submit bot mentioned this pull request Jul 31, 2024
Merged
8 tasks
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Jul 31, 2024
auto-submit bot added a commit that referenced this pull request Jul 31, 2024
@auto-submit
Reverts "[iOS][macOS] Eliminate use of bitcode_strip (#54240)" (#54250)
3b31b21 
Reverts: #54240
Initiated by: zanderso
Reason for reverting: Looks like some issue with file permissions https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20plugin_test_macos/19179/overview
Original PR Author: cbracken

Reviewed By: {zanderso}

This change reverts the following previous change:
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location.

Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details.

Issue: flutter/flutter#107884

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
59351b437 [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine…
9d2713a 
…#54240)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
Roll Flutter Engine from b73367a30e9b to 3b31b21599d1 (8 revisions) (#…
86a4c93 
…152625)

flutter/engine@b73367a...3b31b21

2024-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS][macOS] Eliminate use of bitcode_strip (#54240)" (flutter/engine#54250)
2024-07-31 [email protected] Roll Skia from fa9ecbb258b1 to 999e3f113dbf (1 revision) (flutter/engine#54248)
2024-07-31 [email protected] Roll Dart SDK from f10a21fcc61c to edace067d950 (1 revision) (flutter/engine#54246)
2024-07-31 [email protected] Roll Skia from cb6ea5bd807d to fa9ecbb258b1 (3 revisions) (flutter/engine#54245)
2024-07-31 [email protected] Roll Dart SDK from 68e559110999 to f10a21fcc61c (2 revisions) (flutter/engine#54244)
2024-07-31 [email protected] Roll Skia from 26eb1876de72 to cb6ea5bd807d (2 revisions) (flutter/engine#54241)
2024-07-31 [email protected] Roll Skia from b6036baeebbd to 26eb1876de72 (1 revision) (flutter/engine#54239)
2024-07-31 [email protected] [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@cbracken cbracken mentioned this pull request Jul 31, 2024
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Jul 31, 2024
@cbracken
[iOS][macOS] Eliminate use of bitcode_strip (#54254)
6222eaa 
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location.

Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details.

This is a reland of #54240 which was reverted in #54250.

The the previous version was reverted because Python's `shutil.copyfile` doesn't set the unix permissions of the source file on the destination file. However, when overwriting an existing destination file, it preserves any permissions on that file. One can imagine how this might be problematic if you test the script by running before and after the change with the same output directory. `shutil.copy2` attempts to preserve source file metadata when writing the copy.

Issue: flutter/flutter#107884

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@engine-flutter-autoroll @TytaniumDev
Roll Flutter Engine from b73367a30e9b to 3b31b21599d1 (8 revisions) (f…
e0e7cfd 
…lutter#152625)

flutter/engine@b73367a...3b31b21

2024-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS][macOS] Eliminate use of bitcode_strip (flutter#54240)" (flutter/engine#54250)
2024-07-31 [email protected] Roll Skia from fa9ecbb258b1 to 999e3f113dbf (1 revision) (flutter/engine#54248)
2024-07-31 [email protected] Roll Dart SDK from f10a21fcc61c to edace067d950 (1 revision) (flutter/engine#54246)
2024-07-31 [email protected] Roll Skia from cb6ea5bd807d to fa9ecbb258b1 (3 revisions) (flutter/engine#54245)
2024-07-31 [email protected] Roll Dart SDK from 68e559110999 to f10a21fcc61c (2 revisions) (flutter/engine#54244)
2024-07-31 [email protected] Roll Skia from 26eb1876de72 to cb6ea5bd807d (2 revisions) (flutter/engine#54241)
2024-07-31 [email protected] Roll Skia from b6036baeebbd to 26eb1876de72 (1 revision) (flutter/engine#54239)
2024-07-31 [email protected] [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Roll Flutter Engine from b73367a30e9b to 3b31b21599d1 (8 revisions) (f…
3e637a4 
…lutter#152625)

flutter/engine@b73367a...3b31b21

2024-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS][macOS] Eliminate use of bitcode_strip (flutter#54240)" (flutter/engine#54250)
2024-07-31 [email protected] Roll Skia from fa9ecbb258b1 to 999e3f113dbf (1 revision) (flutter/engine#54248)
2024-07-31 [email protected] Roll Dart SDK from f10a21fcc61c to edace067d950 (1 revision) (flutter/engine#54246)
2024-07-31 [email protected] Roll Skia from cb6ea5bd807d to fa9ecbb258b1 (3 revisions) (flutter/engine#54245)
2024-07-31 [email protected] Roll Dart SDK from 68e559110999 to f10a21fcc61c (2 revisions) (flutter/engine#54244)
2024-07-31 [email protected] Roll Skia from 26eb1876de72 to cb6ea5bd807d (2 revisions) (flutter/engine#54241)
2024-07-31 [email protected] Roll Skia from b6036baeebbd to 26eb1876de72 (1 revision) (flutter/engine#54239)
2024-07-31 [email protected] [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmagman jmagman Awaiting requested review from jmagman

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbracken @zanderso