Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

This debugging tool does not give accurate measurements and we've decided to remove it.

See also: flutter/flutter#131941

Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye code!

DestroyShell(std::move(shell));
}

// ktz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what this comment meant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much that once was is lost

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 29, 2024
@auto-submit auto-submit bot merged commit 6613428 into flutter:main Jul 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 29, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 29, 2024
…152521)

flutter/engine@240fb46...49324cd

2024-07-29 [email protected] Roll Skia from efd1d5b127ae to 62e955dbaef0 (5 revisions) (flutter/engine#54194)
2024-07-29 [email protected] [iOS] leak a single overlay layer. (flutter/engine#54189)
2024-07-29 [email protected] [engine] remove raster stats feature. (flutter/engine#54187)
2024-07-29 [email protected] Revert "Set GLArea.has-alpha = true (#54053)" (flutter/engine#54190)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…lutter#152521)

flutter/engine@240fb46...49324cd

2024-07-29 [email protected] Roll Skia from efd1d5b127ae to 62e955dbaef0 (5 revisions) (flutter/engine#54194)
2024-07-29 [email protected] [iOS] leak a single overlay layer. (flutter/engine#54189)
2024-07-29 [email protected] [engine] remove raster stats feature. (flutter/engine#54187)
2024-07-29 [email protected] Revert "Set GLArea.has-alpha = true (flutter#54053)" (flutter/engine#54190)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#152521)

flutter/engine@240fb46...49324cd

2024-07-29 [email protected] Roll Skia from efd1d5b127ae to 62e955dbaef0 (5 revisions) (flutter/engine#54194)
2024-07-29 [email protected] [iOS] leak a single overlay layer. (flutter/engine#54189)
2024-07-29 [email protected] [engine] remove raster stats feature. (flutter/engine#54187)
2024-07-29 [email protected] Revert "Set GLArea.has-alpha = true (flutter#54053)" (flutter/engine#54190)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants