This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[DisplayList] Optimize ClipRRect and ClipPath to ClipOval when appropriate #54088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Since this change was originally part of a PR that had to be reverted, this (more focused) PR will be put through the "Large Scale Scuba Changes" process to prevent a large triage operation upstream. |
jonahwilliams
approved these changes
Jul 25, 2024
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
Please let me know if you need anything for the LSSC.
flar
force-pushed
the
displaylist-optimize-cliprrect-clippath
branch
from
449d50e to
706f4a3
Compare
flar
force-pushed
the
displaylist-optimize-cliprrect-clippath
branch
from
706f4a3 to
f65ca5f
Compare
Contributor
Author
|
A dry run of this PR into upstream tests didn't show any of the breakages from the original PR. It's possible that we got something wrong in the dry run, but I'm going to merge this speculatively to find out. It should be a simple revert if we find otherwise... |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 26, 2024
…152388) flutter/engine@354abf2...e28f875 2024-07-26 [email protected] [DisplayList] Optimize ClipRRect and ClipPath to ClipOval when appropriate (flutter/engine#54088) 2024-07-26 [email protected] Set GLArea.has-alpha = true (flutter/engine#54053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152388) flutter/engine@354abf2...e28f875 2024-07-26 [email protected] [DisplayList] Optimize ClipRRect and ClipPath to ClipOval when appropriate (flutter/engine#54088) 2024-07-26 [email protected] Set GLArea.has-alpha = true (flutter/engine#54053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152388) flutter/engine@354abf2...e28f875 2024-07-26 [email protected] [DisplayList] Optimize ClipRRect and ClipPath to ClipOval when appropriate (flutter/engine#54088) 2024-07-26 [email protected] Set GLArea.has-alpha = true (flutter/engine#54053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: flutter/flutter#151850
Re-adding an optimization originally included in #53642 that detects when ClipRRect and ClipPath operations are actually ovals and redirects them to the ClipOval path during recording to save space and reduce the need for dispatchers to do the same detections and optimizations.