This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Android] Support HC platform views without thread merging. #53882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Jul 15, 2024
added 2 commits
July 15, 2024 12:57
jonahwilliams
commented
Jul 15, 2024
| // until the device produces a new frame. | ||
| // 3. While the engine will also stop producing frames, there is a race condition. | ||
| final Image newImage = imageReader.acquireLatestImage(); | ||
| final Image newImage = imageReader.acquireNextImage(); |
There was a problem hiding this comment.
Need to check if we use this in other places. We want to use nextIMage because we want to block on scheduling.
This comment was marked as outdated.
This comment was marked as outdated.
added 2 commits
August 7, 2024 15:40
jonahwilliams
force-pushed
the
android_surface_hc
branch
from
5f1a7a2 to
6498528
Compare
|
After investigating this for a few weeks, I think I've concluded that in its present form - making HC platform views not require a thread merge is infesible. The confusing initialization/de-iniitialzation order. combined with the state split across the C++/Java classes is just np too hard to manage. Instead, Im going to focus on refactoring so that the external_view_embedder manages the state directly and can more easily remove thread merging in the future when we do Hc++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the existing hybrid composition mode to remove the need to merge the platform and raster thread. While accessing a GL context across threads is not feasible, the fact that we use image reader surfaces means we can ignore and let the calls to getNext/LatestImage pull out the right AHBs.