This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Reland [DisplayList] Add support for clipOval to leverage Impeller optimization" #53705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eller op…" This reverts commit d6ee3ab.
Contributor
|
Ooof |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 3, 2024
…verage Impeller optimization" (flutter/engine#53705)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 3, 2024
…151212) flutter/engine@c5c0c54...a02e3f6 2024-07-03 [email protected] Revert "Reland [DisplayList] Add support for clipOval to leverage Impeller optimization" (flutter/engine#53705) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
|
This had a good effect on |
Member
Contributor
|
What is diff median though? |
Contributor
|
Oh ouch that looks like a big regression in raster time. @flar I would recommend dropping this for now, we can come back to it later when we have time to make sense of the goldens/performance issues. |
Contributor
|
Is that on Skia? The test doesn't have "impeller" in the name and it's not iOS or macOS so I'm guessing this isn't because the Impeller clipOval path is slower...? |
Contributor
|
Those are Skia tests. |
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
…lutter#151212) flutter/engine@c5c0c54...a02e3f6 2024-07-03 [email protected] Revert "Reland [DisplayList] Add support for clipOval to leverage Impeller optimization" (flutter/engine#53705) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #53642
This change causes 10k golden updates internally and we need to land this out of band (go/lssc). There is also an existing issue with one particular client screenshot test - see b/350129213 for more details.