This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Android] Call restartInput selectively on clear #53662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinmc: Do you have the cycles to take a look at this? |
justinmc
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
LGTM 👍 . Sorry for the delay here.
@bleroux Have you confirmed that flutter/flutter#51478 and flutter/flutter#70546 are still fixed after this change?
|
@justinmc Yes, I have check that the pointed issues are still fixed for their given code sample s. Nonetheless it will be possible to reproduce those issues by setting the text input actions to someone else than none and done. |
|
From triage: @bleroux Is this ready to merge? |
Yes, it is. I was out of the office this week. Let me add the auto submit label. |
bleroux
added
the
autosubmit
bleroux
deleted the
android_restart_input_on_clear_for_some_input_actions
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 18, 2024
…151998) flutter/engine@564ded4...766f7be 2024-07-18 [email protected] [Android] Call restartInput selectively on clear (flutter/engine#53662) 2024-07-18 [email protected] Roll buildroot to 327906297b49980748ea1956019829e7c434a03e (flutter/engine#53994) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 30, 2024
Closed
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
## Description This PR reverts two commits #49829 and #53662. The main change was in #49829. #53662 was a follow-up to mitigate the impact of #49829. ## Related Issue Fixes flutter/flutter#148530 Fixes flutter/flutter#152620 Reopens flutter/flutter#70546. Reopens flutter/flutter#51478
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#151998) flutter/engine@564ded4...766f7be 2024-07-18 [email protected] [Android] Call restartInput selectively on clear (flutter/engine#53662) 2024-07-18 [email protected] Roll buildroot to 327906297b49980748ea1956019829e7c434a03e (flutter/engine#53994) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#151998) flutter/engine@564ded4...766f7be 2024-07-18 [email protected] [Android] Call restartInput selectively on clear (flutter/engine#53662) 2024-07-18 [email protected] Roll buildroot to 327906297b49980748ea1956019829e7c434a03e (flutter/engine#53994) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restricts the call to
restartInputwhich was added in #49829.The restart is called when input action is null, DONE, or NONE.
Related Issue
Fixes flutter/flutter#148673.
Tests
Updates 1 test, adds 3 tests.