This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] omit inferred types in web_ui #53648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think this is LGTM; but I'll leave it to you guys since its |
kevmoo
reviewed
Jul 1, 2024
| public_member_api_docs: false | ||
| unawaited_futures: true | ||
| use_setters_to_change_properties: false | ||
| omit_local_variable_types: true |
Contributor
There was a problem hiding this comment.
might want to be clean and sort these!
Contributor
Author
Still feeling uneasy about this. Had I landed this PR, this revert would have been a nightmare :/ |
Contributor
|
There is no way through this without dealing with the potential mess |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
omit_local_variable_typeslint and calldart fix --applyinlib/web_ui.