This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[DisplayList] Add support for clipOval to leverage Impeller optimization" #53629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptimizat…" This reverts commit aa9afcd.
jason-simmons
approved these changes
Jun 28, 2024
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2024
…Impeller optimization" (flutter/engine#53629)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2024
…Impeller optimization" (flutter/engine#53629)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 28, 2024
…151002) flutter/engine@a78f5ce...2f7e9ab 2024-06-28 [email protected] Roll Skia from 7a09d38fa7f8 to 3d5f5d546fb6 (1 revision) (flutter/engine#53634) 2024-06-28 [email protected] Roll Skia from 23a14cccc800 to 7a09d38fa7f8 (1 revision) (flutter/engine#53633) 2024-06-28 [email protected] Roll Skia from cd77153f20a8 to 23a14cccc800 (1 revision) (flutter/engine#53631) 2024-06-28 [email protected] Revert "[DisplayList] Add support for clipOval to leverage Impeller optimization" (flutter/engine#53629) 2024-06-28 [email protected] Roll Dart SDK from 4005e5f1fb8e to 341dbaf977a3 (1 revision) (flutter/engine#53630) 2024-06-28 [email protected] Roll Skia from 6650fcc6d054 to cd77153f20a8 (1 revision) (flutter/engine#53628) 2024-06-28 [email protected] Roll Skia from 2204428a75ca to 6650fcc6d054 (2 revisions) (flutter/engine#53627) 2024-06-28 [email protected] Roll Dart SDK from 0820b0766ac9 to 4005e5f1fb8e (1 revision) (flutter/engine#53626) 2024-06-28 [email protected] Roll Skia from 1700e3962acd to 2204428a75ca (1 revision) (flutter/engine#53625) 2024-06-28 [email protected] Roll Fuchsia Linux SDK from gBWzGuicxu76K82lg... to H_P7EHb4zXXV-Eiik... (flutter/engine#53624) 2024-06-28 [email protected] [DisplayList] Add support for clipOval to leverage Impeller optimization (flutter/engine#53622) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from gBWzGuicxu76 to H_P7EHb4zXXV If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
…lutter#151002) flutter/engine@a78f5ce...2f7e9ab 2024-06-28 [email protected] Roll Skia from 7a09d38fa7f8 to 3d5f5d546fb6 (1 revision) (flutter/engine#53634) 2024-06-28 [email protected] Roll Skia from 23a14cccc800 to 7a09d38fa7f8 (1 revision) (flutter/engine#53633) 2024-06-28 [email protected] Roll Skia from cd77153f20a8 to 23a14cccc800 (1 revision) (flutter/engine#53631) 2024-06-28 [email protected] Revert "[DisplayList] Add support for clipOval to leverage Impeller optimization" (flutter/engine#53629) 2024-06-28 [email protected] Roll Dart SDK from 4005e5f1fb8e to 341dbaf977a3 (1 revision) (flutter/engine#53630) 2024-06-28 [email protected] Roll Skia from 6650fcc6d054 to cd77153f20a8 (1 revision) (flutter/engine#53628) 2024-06-28 [email protected] Roll Skia from 2204428a75ca to 6650fcc6d054 (2 revisions) (flutter/engine#53627) 2024-06-28 [email protected] Roll Dart SDK from 0820b0766ac9 to 4005e5f1fb8e (1 revision) (flutter/engine#53626) 2024-06-28 [email protected] Roll Skia from 1700e3962acd to 2204428a75ca (1 revision) (flutter/engine#53625) 2024-06-28 [email protected] Roll Fuchsia Linux SDK from gBWzGuicxu76K82lg... to H_P7EHb4zXXV-Eiik... (flutter/engine#53624) 2024-06-28 [email protected] [DisplayList] Add support for clipOval to leverage Impeller optimization (flutter/engine#53622) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from gBWzGuicxu76 to H_P7EHb4zXXV If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #53622
There were some golden changes which might be minor, but they weren't expected. Also, I noticed a problem in reducing drawPath down to drawRect and drawOval - that should not be done if the path has the inverse fill flag set...