This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] experimental canvas bdf support. #53597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Gonna run tests with this enabled to see what it does, then opt it back out. |
bdero
reviewed
Jun 27, 2024
impeller/aiks/experimental_canvas.cc
Outdated
Comment on lines
347
to
348
| subpass_coverage = clip_coverage_stack_.CurrentClipCoverage().value_or( | ||
| save_layer_state_.back().coverage); |
Member
There was a problem hiding this comment.
IIUC from earlier, the plan is to do a Save() instead in cases where this ends up being zero size in order to avoid making a zero size texture/RenderPass?
Then, stuff appended within the "skipped" SaveLayer may still append draws, but they shouldn't be able to draw anything into the parent texture given the zero size scissor.
Contributor
Author
There was a problem hiding this comment.
This is done now. Also, on partial repaint examples we have fewer composited layers compared to the current entity pass. I'm not sure why the current entity pass skip logic doesn't seem to work at eliding the entire layer when there are backdrops.
Experimental Canvas
Current
Contributor
Author
|
Fixed the entity pass target flip/allocate calls, so now we're correctly reusing textures. I realized that tracking the required mip count requires more information than we have. When we get a bdf, its the previous render target that needed to be created with mips. |
added 4 commits
June 27, 2024 21:22
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 29, 2024
…151016) flutter/engine@f828363...ad1343c 2024-06-28 [email protected] [web] switch from .didGain/LoseAccessibilityFocus to .focus (flutter/engine#53360) 2024-06-28 [email protected] Reland [DisplayList] Add support for clipOval to leverage Impeller optimization (flutter/engine#53642) 2024-06-28 [email protected] [Impeller] experimental canvas bdf support. (flutter/engine#53597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
…lutter#151016) flutter/engine@f828363...ad1343c 2024-06-28 [email protected] [web] switch from .didGain/LoseAccessibilityFocus to .focus (flutter/engine#53360) 2024-06-28 [email protected] Reland [DisplayList] Add support for clipOval to leverage Impeller optimization (flutter/engine#53642) 2024-06-28 [email protected] [Impeller] experimental canvas bdf support. (flutter/engine#53597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost working bdf for experimentcal canvas.
Currently there are some problems with the clip depth, and positioning of the backdrop filter. I think I am not taking the blur transform into account at the very least.
FYI @bdero