Move impeller-cmake-example to flutter/third_party. #53589
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
matanlurey
added
the
autosubmit
| @@ -1008,7 +1008,7 @@ deps = { | |||
| 'dep_type': 'cipd', | |||
| }, | |||
|
|
|||
| 'src/third_party/impeller-cmake-example': { | |||
| 'src/flutter/third_party/impeller-cmake-example': { | |||
There was a problem hiding this comment.
I think one more change is needed for this actually
There was a problem hiding this comment.
I think this path needs to be updated:
Line 1139 in e03cf86
There was a problem hiding this comment.
Ah good catch, ack
matanlurey
removed
the
autosubmit
matanlurey
added
the
autosubmit
…150875) flutter/engine@e03cf86...1d5e3cc 2024-06-26 [email protected] Replace `Log.w` with `Log.d`, and tidy the file up a bit. (flutter/engine#53586) 2024-06-26 [email protected] Roll Skia from 695d35a0559e to 0a979d9f3606 (3 revisions) (flutter/engine#53591) 2024-06-26 [email protected] Move impeller-cmake-example to flutter/third_party. (flutter/engine#53589) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
... as part of buildmoot.
I think this is all that is needed but am not confident.