This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] add missing position to exp canvas text. #53339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flar
approved these changes
Jun 11, 2024
| @@ -391,6 +391,7 @@ void ExperimentalCanvas::DrawTextFrame( | |||
| text_contents->SetForceTextColor(paint.mask_blur_descriptor.has_value()); | |||
| text_contents->SetScale(GetCurrentTransform().GetMaxBasisLengthXY()); | |||
| text_contents->SetColor(paint.color); | |||
| text_contents->SetOffset(position); | |||
There was a problem hiding this comment.
That looks necessary. I'm confused as to why this version has a call to SetScale while the regular canvas version does not. Is that another issue?
There was a problem hiding this comment.
For the regular canvas, we populate the scale when populating the glyph atlas:
https://github.com/flutter/engine/blob/main/impeller/entity/contents/text_contents.cc#L66-L71
There was a problem hiding this comment.
Ah, and for the experimental canvas that is done before the TextContents exists. I see...
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 13, 2024
…150199) flutter/engine@c7fcbfc...4cb3025 2024-06-13 [email protected] Roll Skia from 0fe7f7ac43c5 to ecc64fb82374 (1 revision) (flutter/engine#53374) 2024-06-13 [email protected] Roll Skia from 9ea9f37e8e1d to 0fe7f7ac43c5 (1 revision) (flutter/engine#53373) 2024-06-13 [email protected] Roll Skia from b12af56eb100 to 9ea9f37e8e1d (1 revision) (flutter/engine#53372) 2024-06-13 [email protected] Roll Skia from 704f70b7d756 to b12af56eb100 (1 revision) (flutter/engine#53371) 2024-06-13 [email protected] Roll Skia from 69a53db434a6 to 704f70b7d756 (2 revisions) (flutter/engine#53370) 2024-06-13 [email protected] Roll Skia from b2f163ae11bf to 69a53db434a6 (8 revisions) (flutter/engine#53365) 2024-06-13 [email protected] [Impeller] Move Gradient tests to display list. (flutter/engine#53345) 2024-06-13 [email protected] Roll Fuchsia Linux SDK from 5VG7IYkpANkfxMKYx... to pGxbL7JoNb3yAYFw4... (flutter/engine#53363) 2024-06-13 [email protected] Roll Skia from be6a57569a92 to b2f163ae11bf (5 revisions) (flutter/engine#53357) 2024-06-13 [email protected] Give mac_host_engine tests a longer timeout and allow to run on Mac-14 (flutter/engine#53355) 2024-06-13 [email protected] 'Starter Project': port planet fragment shader to impeller tests (flutter/engine#53362) 2024-06-12 [email protected] Roll Skia from 1ba0c3ebc7a5 to be6a57569a92 (1 revision) (flutter/engine#53353) 2024-06-12 [email protected] Roll Dart SDK from 24fbead7105d to aa2265e5a192 (1 revision) (flutter/engine#53352) 2024-06-12 [email protected] Roll Skia from 52d829ac6a0b to 1ba0c3ebc7a5 (1 revision) (flutter/engine#53351) 2024-06-12 [email protected] Roll Skia from 5bfbacc89543 to 52d829ac6a0b (1 revision) (flutter/engine#53350) 2024-06-12 [email protected] Roll Skia from 51eabd0d1e44 to 5bfbacc89543 (1 revision) (flutter/engine#53349) 2024-06-12 [email protected] Roll Dart SDK from b61536f05f99 to 24fbead7105d (1 revision) (flutter/engine#53348) 2024-06-12 [email protected] Roll Dart SDK from 269125c33a35 to b61536f05f99 (1 revision) (flutter/engine#53347) 2024-06-12 [email protected] [Impeller] disabling the color write mask seems to improve performance on iOS compared to just the blend options. (flutter/engine#53322) 2024-06-11 [email protected] Roll Fuchsia Linux SDK from LS0Ff8PwQEGXzO0iA... to 5VG7IYkpANkfxMKYx... (flutter/engine#53346) 2024-06-11 [email protected] Roll Dart SDK from ab4d5a0b789d to 269125c33a35 (1 revision) (flutter/engine#53344) 2024-06-11 [email protected] [Impeller] makes bgra10xr test more comprehensive (flutter/engine#53320) 2024-06-11 [email protected] Roll Skia from af907b24d873 to 51eabd0d1e44 (1 revision) (flutter/engine#53343) 2024-06-11 [email protected] [Impeller] add missing position to exp canvas text. (flutter/engine#53339) 2024-06-11 [email protected] Roll Skia from 4cbc1129e587 to af907b24d873 (1 revision) (flutter/engine#53341) 2024-06-11 [email protected] Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus (â�¦ (flutter/engine#53342) 2024-06-11 [email protected] [Impeller] move some tests from aiks to display list. (flutter/engine#53336) 2024-06-11 [email protected] Roll Skia from b5f974ec2dcd to 4cbc1129e587 (1 revision) (flutter/engine#53340) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from LS0Ff8PwQEGX to pGxbL7JoNb3y If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…lutter#150199) flutter/engine@c7fcbfc...4cb3025 2024-06-13 [email protected] Roll Skia from 0fe7f7ac43c5 to ecc64fb82374 (1 revision) (flutter/engine#53374) 2024-06-13 [email protected] Roll Skia from 9ea9f37e8e1d to 0fe7f7ac43c5 (1 revision) (flutter/engine#53373) 2024-06-13 [email protected] Roll Skia from b12af56eb100 to 9ea9f37e8e1d (1 revision) (flutter/engine#53372) 2024-06-13 [email protected] Roll Skia from 704f70b7d756 to b12af56eb100 (1 revision) (flutter/engine#53371) 2024-06-13 [email protected] Roll Skia from 69a53db434a6 to 704f70b7d756 (2 revisions) (flutter/engine#53370) 2024-06-13 [email protected] Roll Skia from b2f163ae11bf to 69a53db434a6 (8 revisions) (flutter/engine#53365) 2024-06-13 [email protected] [Impeller] Move Gradient tests to display list. (flutter/engine#53345) 2024-06-13 [email protected] Roll Fuchsia Linux SDK from 5VG7IYkpANkfxMKYx... to pGxbL7JoNb3yAYFw4... (flutter/engine#53363) 2024-06-13 [email protected] Roll Skia from be6a57569a92 to b2f163ae11bf (5 revisions) (flutter/engine#53357) 2024-06-13 [email protected] Give mac_host_engine tests a longer timeout and allow to run on Mac-14 (flutter/engine#53355) 2024-06-13 [email protected] 'Starter Project': port planet fragment shader to impeller tests (flutter/engine#53362) 2024-06-12 [email protected] Roll Skia from 1ba0c3ebc7a5 to be6a57569a92 (1 revision) (flutter/engine#53353) 2024-06-12 [email protected] Roll Dart SDK from 24fbead7105d to aa2265e5a192 (1 revision) (flutter/engine#53352) 2024-06-12 [email protected] Roll Skia from 52d829ac6a0b to 1ba0c3ebc7a5 (1 revision) (flutter/engine#53351) 2024-06-12 [email protected] Roll Skia from 5bfbacc89543 to 52d829ac6a0b (1 revision) (flutter/engine#53350) 2024-06-12 [email protected] Roll Skia from 51eabd0d1e44 to 5bfbacc89543 (1 revision) (flutter/engine#53349) 2024-06-12 [email protected] Roll Dart SDK from b61536f05f99 to 24fbead7105d (1 revision) (flutter/engine#53348) 2024-06-12 [email protected] Roll Dart SDK from 269125c33a35 to b61536f05f99 (1 revision) (flutter/engine#53347) 2024-06-12 [email protected] [Impeller] disabling the color write mask seems to improve performance on iOS compared to just the blend options. (flutter/engine#53322) 2024-06-11 [email protected] Roll Fuchsia Linux SDK from LS0Ff8PwQEGXzO0iA... to 5VG7IYkpANkfxMKYx... (flutter/engine#53346) 2024-06-11 [email protected] Roll Dart SDK from ab4d5a0b789d to 269125c33a35 (1 revision) (flutter/engine#53344) 2024-06-11 [email protected] [Impeller] makes bgra10xr test more comprehensive (flutter/engine#53320) 2024-06-11 [email protected] Roll Skia from af907b24d873 to 51eabd0d1e44 (1 revision) (flutter/engine#53343) 2024-06-11 [email protected] [Impeller] add missing position to exp canvas text. (flutter/engine#53339) 2024-06-11 [email protected] Roll Skia from 4cbc1129e587 to af907b24d873 (1 revision) (flutter/engine#53341) 2024-06-11 [email protected] Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus (â�¦ (flutter/engine#53342) 2024-06-11 [email protected] [Impeller] move some tests from aiks to display list. (flutter/engine#53336) 2024-06-11 [email protected] Roll Skia from b5f974ec2dcd to 4cbc1129e587 (1 revision) (flutter/engine#53340) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from LS0Ff8PwQEGX to pGxbL7JoNb3y If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…lutter#150199) flutter/engine@c7fcbfc...4cb3025 2024-06-13 [email protected] Roll Skia from 0fe7f7ac43c5 to ecc64fb82374 (1 revision) (flutter/engine#53374) 2024-06-13 [email protected] Roll Skia from 9ea9f37e8e1d to 0fe7f7ac43c5 (1 revision) (flutter/engine#53373) 2024-06-13 [email protected] Roll Skia from b12af56eb100 to 9ea9f37e8e1d (1 revision) (flutter/engine#53372) 2024-06-13 [email protected] Roll Skia from 704f70b7d756 to b12af56eb100 (1 revision) (flutter/engine#53371) 2024-06-13 [email protected] Roll Skia from 69a53db434a6 to 704f70b7d756 (2 revisions) (flutter/engine#53370) 2024-06-13 [email protected] Roll Skia from b2f163ae11bf to 69a53db434a6 (8 revisions) (flutter/engine#53365) 2024-06-13 [email protected] [Impeller] Move Gradient tests to display list. (flutter/engine#53345) 2024-06-13 [email protected] Roll Fuchsia Linux SDK from 5VG7IYkpANkfxMKYx... to pGxbL7JoNb3yAYFw4... (flutter/engine#53363) 2024-06-13 [email protected] Roll Skia from be6a57569a92 to b2f163ae11bf (5 revisions) (flutter/engine#53357) 2024-06-13 [email protected] Give mac_host_engine tests a longer timeout and allow to run on Mac-14 (flutter/engine#53355) 2024-06-13 [email protected] 'Starter Project': port planet fragment shader to impeller tests (flutter/engine#53362) 2024-06-12 [email protected] Roll Skia from 1ba0c3ebc7a5 to be6a57569a92 (1 revision) (flutter/engine#53353) 2024-06-12 [email protected] Roll Dart SDK from 24fbead7105d to aa2265e5a192 (1 revision) (flutter/engine#53352) 2024-06-12 [email protected] Roll Skia from 52d829ac6a0b to 1ba0c3ebc7a5 (1 revision) (flutter/engine#53351) 2024-06-12 [email protected] Roll Skia from 5bfbacc89543 to 52d829ac6a0b (1 revision) (flutter/engine#53350) 2024-06-12 [email protected] Roll Skia from 51eabd0d1e44 to 5bfbacc89543 (1 revision) (flutter/engine#53349) 2024-06-12 [email protected] Roll Dart SDK from b61536f05f99 to 24fbead7105d (1 revision) (flutter/engine#53348) 2024-06-12 [email protected] Roll Dart SDK from 269125c33a35 to b61536f05f99 (1 revision) (flutter/engine#53347) 2024-06-12 [email protected] [Impeller] disabling the color write mask seems to improve performance on iOS compared to just the blend options. (flutter/engine#53322) 2024-06-11 [email protected] Roll Fuchsia Linux SDK from LS0Ff8PwQEGXzO0iA... to 5VG7IYkpANkfxMKYx... (flutter/engine#53346) 2024-06-11 [email protected] Roll Dart SDK from ab4d5a0b789d to 269125c33a35 (1 revision) (flutter/engine#53344) 2024-06-11 [email protected] [Impeller] makes bgra10xr test more comprehensive (flutter/engine#53320) 2024-06-11 [email protected] Roll Skia from af907b24d873 to 51eabd0d1e44 (1 revision) (flutter/engine#53343) 2024-06-11 [email protected] [Impeller] add missing position to exp canvas text. (flutter/engine#53339) 2024-06-11 [email protected] Roll Skia from 4cbc1129e587 to af907b24d873 (1 revision) (flutter/engine#53341) 2024-06-11 [email protected] Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus (â�¦ (flutter/engine#53342) 2024-06-11 [email protected] [Impeller] move some tests from aiks to display list. (flutter/engine#53336) 2024-06-11 [email protected] Roll Skia from b5f974ec2dcd to 4cbc1129e587 (1 revision) (flutter/engine#53340) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from LS0Ff8PwQEGX to pGxbL7JoNb3y If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing when I wired up subpixel alignment for the regualr canvas, causing glyphs to not be found with experimental canvas.
Part of flutter/flutter#142054