This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update .engine-release.version #53148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update on release branch to fix impeller golden failure.
fluttergithubbot
approved these changes
May 31, 2024
gaaclarke
approved these changes
May 31, 2024
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
lgtm, number is in the right format and the PR is destined to the right branch.
itsjustkevin
added
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
In the previous build ([pr](#53148) [build](https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac%20Production%20Engine%20Drone/12733/infra)), the impeller golden tests failed (maybe because they were testing against the main branch goldens?), and thus mac release arm64 binaries were never uploaded. This PR deletes the target from the ci/builders/*.json file so that we can successfully build and upload mac binaries.
This was referenced Jun 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update version on the new beta branch to fix impeller golden failures.