This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Log Vulkan loader errors if the instance failed creation on Fuchsia #52935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbauman42
force-pushed
the
logvulkancreationerror
branch
2 times, most recently
from
760c345 to
95ad929
Compare
Member
|
(triage) I spoke to @jbauman42 last week and they indicated plans to come back to this at some point. |
jbauman42
force-pushed
the
logvulkancreationerror
branch
9 times, most recently
from
91cfae8 to
bd1acfd
Compare
jbauman42
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
The vulkan loader can output logs to help us debug why instance creation fails. To catch these logs, we need to pass a debug report callback to vkCreateInstance (since the only other debug report callback is set up after the instance is created). Fixes flutter/flutter#82928
jbauman42
force-pushed
the
logvulkancreationerror
branch
from
bd1acfd to
04c1f45
Compare
chinmaygarde
approved these changes
Sep 30, 2024
Contributor
Author
|
Chinmay, could you submit this? I don't have write access to the repo. |
Member
|
Wilco. Fetching a second reviewer. Consider go/flutter-onboarding to become a contributor 🙏🏽 |
jtmcdole
approved these changes
Oct 1, 2024
jtmcdole
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 1, 2024
…156019) flutter/engine@e127e78...a609ee6 2024-10-01 [email protected] Roll Dart SDK from 0e8b99c3154a to 345a9d8d3f1c (1 revision) (flutter/engine#55564) 2024-10-01 [email protected] Log Vulkan loader errors if the instance failed creation on Fuchsia (flutter/engine#52935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 18, 2024
…lutter/engine#52935) Log Vulkan loader errors if the instance failed creation on Fuchsia The vulkan loader can output logs to help us debug why instance creation fails. To catch these logs, we need to pass a debug report callback to vkCreateInstance (since the only other debug report callback is set up after the instance is created). Outputting logs is currently only enabled on Fuchsia, since other platforms may have fallbacks and wouldn't want the error logspam. Fixes #82928 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log Vulkan loader errors if the instance failed creation on Fuchsia
The vulkan loader can output logs to help us debug why instance creation
fails. To catch these logs, we need to pass a debug report callback to
vkCreateInstance (since the only other debug report callback is set up
after the instance is created).
Outputting logs is currently only enabled on Fuchsia, since other
platforms may have fallbacks and wouldn't want the error logspam.
Fixes flutter/flutter#82928
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.