Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented May 14, 2024

@jason-simmons jason-simmons added the test: all See https://github.com/flutter/engine/blob/main/docs/ci/Engine-pre-submits-and-post-submits.md label May 14, 2024
@jason-simmons jason-simmons requested a review from zanderso May 15, 2024 22:22
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2024
@auto-submit auto-submit bot merged commit 1850def into flutter:main May 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 16, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 16, 2024
…148507)

flutter/engine@6fa734d...1850def

2024-05-16 [email protected] Manual roll of Clang from 725656bdd885 to 145176dc0c93 (flutter/engine#52823)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@zanderso
Copy link
Member

Reason for revert: Engine crashes on framework CI following this roll https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_gallery__transition_perf_with_semantics/12126/overview

@zanderso zanderso added the revert Label used to revert changes in a closed and merged pull request. label May 16, 2024
auto-submit bot pushed a commit that referenced this pull request May 16, 2024
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label May 16, 2024
auto-submit bot added a commit that referenced this pull request May 16, 2024
…)" (#52890)

Reverts: #52823
Initiated by: zanderso
Reason for reverting: Engine crashes on framework CI following this roll https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_gallery__transition_perf_with_semantics/12126/overview
Original PR Author: jason-simmons

Reviewed By: {zanderso}

This change reverts the following previous change:
See flutter/flutter#143178
auto-submit bot added a commit to flutter/flutter that referenced this pull request May 16, 2024
…ision) (#148507)" (#148517)

Reverts: #148507
Initiated by: zanderso
Reason for reverting: Engine crashers on Android following the clang roll https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_gallery__transition_perf_with_semantics/12126/overview
Original PR Author: engine-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

flutter/engine@6fa734d...1850def

2024-05-16 [email protected] Manual roll of Clang from 725656bdd885 to 145176dc0c93 (flutter/engine#52823)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 17, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 17, 2024
…ions) (#148528)

Manual roll requested by [email protected]

flutter/engine@6fa734d...8d1a1d8

2024-05-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll of Clang from 725656bdd885 to 145176dc0c93 (#52823)" (flutter/engine#52890)
2024-05-16 [email protected] Roll Skia from bb1572a681eb to 7536d3b590b8 (2 revisions) (flutter/engine#52888)
2024-05-16 [email protected] Roll Skia from 530fa373b797 to bb1572a681eb (2 revisions) (flutter/engine#52886)
2024-05-16 [email protected] Roll Skia from ac4aa1dbd268 to 530fa373b797 (1 revision) (flutter/engine#52881)
2024-05-16 [email protected] Roll Fuchsia Linux SDK from Ftw7GopnudHydGS1y... to ywxGmpIdjxBl2i7s2... (flutter/engine#52882)
2024-05-16 [email protected] Roll Dart SDK from b64b487c9967 to d174ead78d98 (1 revision) (flutter/engine#52878)
2024-05-16 [email protected] Roll Skia from 320b00b025b8 to ac4aa1dbd268 (2 revisions) (flutter/engine#52877)
2024-05-16 [email protected] Manual roll of Clang from 725656bdd885 to 145176dc0c93 (flutter/engine#52823)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Ftw7GopnudHy to ywxGmpIdjxBl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects: desktop autosubmit Merge PR when tree becomes green via auto submit App e: impeller platform-android platform-fuchsia platform-ios platform-linux platform-windows test: all See https://github.com/flutter/engine/blob/main/docs/ci/Engine-pre-submits-and-post-submits.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants