This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] use render pass to clear glyph atlas texture to transparent black. #52791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
jonahwilliams
commented
May 14, 2024
| data.external_format, // external format | ||
| data.type, // type | ||
| tex_data // data | ||
| nullptr // data |
Contributor
Author
There was a problem hiding this comment.
This is correctly initialized below, but needs to be nullptr, or the driver may read out of bounds if we're only updating a subregion.
chinmaygarde
approved these changes
May 14, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 14, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 14, 2024
…148299) flutter/engine@0de6701...b4b798d 2024-05-14 [email protected] Roll Skia from 19153175a79b to 7045b90f1ef8 (3 revisions) (flutter/engine#52801) 2024-05-14 [email protected] [Impeller] use render pass to clear glyph atlas texture to transparent black. (flutter/engine#52791) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #52746
Work towards flutter/flutter#138798
If possible, use a render pass to clear texture to transparent black. The goal is to reduce the CPU cost for larger atlases.