Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Create framebuffer blend vertices based on the snapshot's texture size instead of coverage #52790

Merged
merged 2 commits into from
May 14, 2024
Merged

[Impeller] Create framebuffer blend vertices based on the snapshot's texture size instead of coverage #52790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
782158a
[Impeller] Create framebuffer blend vertices based on the snapshot's …
jason-simmons May 11, 2024
f2ef1bc
golden test output
jason-simmons May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions impeller/aiks/aiks_blend_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,5 +576,20 @@ TEST_P(AiksTest, ForegroundAdvancedBlendAppliesTransformCorrectly) {
ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
}

TEST_P(AiksTest, FramebufferAdvancedBlendCoverage) {
auto texture = CreateTextureForFixture("airplane.jpg",
/*enable_mipmapping=*/true);

// Draw with an advanced blend that can use FramebufferBlendContents and
// verify that the scale transform is correctly applied to the image.
Canvas canvas;
canvas.DrawPaint({.color = Color::DarkGray()});
canvas.Scale(Vector2(0.4, 0.4));
canvas.DrawImage(std::make_shared<Image>(texture), {20, 20},
{.blend_mode = BlendMode::kMultiply});

ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
}

} // namespace testing
} // namespace impeller
7 changes: 1 addition & 6 deletions impeller/entity/contents/framebuffer_blend_contents.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,8 @@ bool FramebufferBlendContents::Render(const ContentContext& renderer,
if (!src_snapshot.has_value()) {
return true;
}
auto coverage = src_snapshot->GetCoverage();
if (!coverage.has_value()) {
return true;
}
Rect src_coverage = coverage.value();

auto size = src_coverage.GetSize();
auto size = src_snapshot->texture->GetSize();
VertexBufferBuilder<VS::PerVertexData> vtx_builder;
vtx_builder.AddVertices({
{Point(0, 0), Point(0, 0)},
Expand Down
3 changes: 3 additions & 0 deletions testing/impeller_golden_tests_output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,9 @@ impeller_Play_AiksTest_ForegroundBlendSubpassCollapseOptimization_Vulkan.png
impeller_Play_AiksTest_ForegroundPipelineBlendAppliesTransformCorrectly_Metal.png
impeller_Play_AiksTest_ForegroundPipelineBlendAppliesTransformCorrectly_OpenGLES.png
impeller_Play_AiksTest_ForegroundPipelineBlendAppliesTransformCorrectly_Vulkan.png
impeller_Play_AiksTest_FramebufferAdvancedBlendCoverage_Metal.png
impeller_Play_AiksTest_FramebufferAdvancedBlendCoverage_OpenGLES.png
impeller_Play_AiksTest_FramebufferAdvancedBlendCoverage_Vulkan.png
impeller_Play_AiksTest_GaussianBlurAnimatedBackdrop_Metal.png
impeller_Play_AiksTest_GaussianBlurAnimatedBackdrop_OpenGLES.png
impeller_Play_AiksTest_GaussianBlurAnimatedBackdrop_Vulkan.png
Expand Down