[Impeller] require and use backpressure for AHB swapchain. #52676
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
According to https://www.gsmarena.com/samsung_galaxy_a02s-10603.php , this device should be upgradable to 31. We can check the resulting timeline. |
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Enabling the backpressure lgtm but I must admit I haven't fully thought through the observation caused this in https://discord.com/channels/608014603317936148/1237818635452416072.
jonahwilliams
added
the
autosubmit
…148010) flutter/engine@9cb60de...93c5040 2024-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from b7cad2edae4b to 673b3aa8558a (1 revision) (#52677)" (flutter/engine#52683) 2024-05-08 [email protected] Roll Skia from d965fc1fd319 to 4019d8957cff (2 revisions) (flutter/engine#52682) 2024-05-08 [email protected] Revert 484688634c71ec38c18218eaa13dc47fa7007b74 (flutter/engine#52680) 2024-05-08 [email protected] Roll Skia from d8427844b843 to d965fc1fd319 (4 revisions) (flutter/engine#52679) 2024-05-08 [email protected] [Impeller] require and use backpressure for AHB swapchain. (flutter/engine#52676) 2024-05-08 [email protected] Roll Dart SDK from b7cad2edae4b to 673b3aa8558a (1 revision) (flutter/engine#52677) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
I think we might be buffer stuffing on the A02s specifically. Though I don't know if this will just "fix" it by turning off the swapchain for that device.
flutter/flutter#147721