This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Migrate third_party/android_tools to flutter/third_party #52582
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
May 6, 2024
Contributor
matanlurey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for helping complete this!
zanderso
approved these changes
May 6, 2024
19d38e1 to
3d85619
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 6, 2024
…147895) flutter/engine@463ff7d...422f92b 2024-05-06 [email protected] Migrate third_party/android_tools to flutter/third_party (flutter/engine#52582) 2024-05-06 [email protected] Roll Skia from a5c042cb4b12 to 869cacf2a3f1 (1 revision) (flutter/engine#52583) 2024-05-06 [email protected] [Impeller] remove unused includes. (flutter/engine#52579) 2024-05-06 [email protected] Roll Skia from da772ace76ff to a5c042cb4b12 (6 revisions) (flutter/engine#52581) 2024-05-06 [email protected] [Impeller] fix missing GPU probe. (flutter/engine#52580) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced May 30, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
May 31, 2024
Fixes flutter/flutter#149319 Caused by #52582 Follow up required to add a flag that fails on missing jar files instead of skipping missing jar files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #52034