[CP][canvaskit] fix: consider array size on canvaskit shader data (#49754) #52400

renancaraujo · 2024-04-25T22:01:17Z

This PR changes the ShaderData construction on canvaskit to consider array uniforms.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

This PR changes the ShaderData construction on canvaskit to consider array uniforms. flutter/flutter#141296 flutter/flutter#141838 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

kevmoo · 2024-05-10T17:54:02Z

What's the story here @yjbanov ?

github-actions bot added the platform-web Code specifically for the web engine label Apr 25, 2024

renancaraujo mentioned this pull request Apr 25, 2024

[CP] Hotfix fragment shaders fix into stable flutter/flutter#147389

Closed

renancaraujo closed this May 14, 2024

renancaraujo deleted the renan.make-shaders-great-again-on-web branch May 16, 2024 13:08