Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

zanderso
Copy link
Member

#52021 introduced a bug where ci build could only be specified when also passing the --verbose flag. This PR fixes the issue so that by default the help message will only show ci builds when --verbose is passed to help, but the ci builds can be specified even without the --verbose flag.

@zanderso zanderso requested a review from cbracken April 23, 2024 22:28
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@zanderso zanderso merged commit fcb1060 into flutter:main Apr 23, 2024
@zanderso zanderso deleted the et-fix-build-help branch April 23, 2024 23:46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 24, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 24, 2024
…147272)

flutter/engine@7f89b43...fcb1060

2024-04-23 [email protected] [et] Don't require the --verbose flag when requesting a ci/ build (flutter/engine#52339)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants