This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Set RGBA8888 as the default Vulkan color format before the app acquires a surface #51770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… app acquires a surface An app may render offscreen images before it gets a window. The ContextVK needs to have a default color format so that render passes can be created before the ContextVK is updated to use the window's format.
jonahwilliams
approved these changes
Mar 29, 2024
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
If we're able to do #51213 , then there is no risk of pixel format mismatching - but even if it does change we should be able to create new shader variants without issue
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
This is definitely the right default on Android.
chinmaygarde
approved these changes
Mar 29, 2024
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2024
…before the app acquires a surface (flutter/engine#51770)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 1, 2024
…146087) flutter/engine@d33666d...8dff6b8 2024-04-01 [email protected] Use the stripped Vulkan validation library in Android engine builds by default (flutter/engine#51628) 2024-04-01 [email protected] [Impeller] Set RGBA8888 as the default Vulkan color format before the app acquires a surface (flutter/engine#51770) 2024-04-01 [email protected] Never panic in `finally { ... }`, check output logs on success only. (flutter/engine#51814) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An app may render offscreen images before it gets a window. The ContextVK needs to have a default color format so that render passes can be created before the ContextVK is updated to use the window's format.