Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@hellohuanlin
Copy link
Contributor

@hellohuanlin hellohuanlin commented Mar 26, 2024

The previous PR flutter/flutter#143420 rounds out the layers and rounds in the platform views. This results in missing pixel on the edge of the intersection when there's fractional coordinate (as shown in the screenshot below), because platform view is below the layers.

This PR rounds in the layers, and rounds out the platform views, so that the edge pixels of the intersection are included in the overlay.

Note that the edge pixel of the layers will give the ownership to platform view. This is just a single (or partial) pixel and will likely be unnoticeable.

Screenshot 2024-03-26 at 11 34 20 AM

List which issues are fixed by this PR. You must list at least one issue.

flutter/flutter#143420

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hellohuanlin hellohuanlin force-pushed the round_in_layers_and_round_out_pv branch 2 times, most recently from 7f6aa8d to c051abb Compare March 26, 2024 19:10
@hellohuanlin hellohuanlin force-pushed the round_in_layers_and_round_out_pv branch from c051abb to b29871e Compare March 26, 2024 20:04
@hellohuanlin hellohuanlin changed the title [ios][platform_view]round in layers and round out platform views [DONT LAND][ios][platform_view]round in layers and round out platform views Mar 26, 2024
@hellohuanlin
Copy link
Contributor Author

closing this in favor of #51687

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant