Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

jonahwilliams
Copy link
Contributor

In theory we could trigger animations by touching certain CALayer/UIView properties, this just explicitly disables them for our compositor.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way we can test this?

@jonahwilliams
Copy link
Contributor Author

Not that I am aware of

@hellohuanlin
Copy link
Contributor

CATransaction can probably be partial-mocked. Though this is only testing the implementation rather than testing the behavior. Since there's no known bad behavior so far, we can't test against it.

If you can get a test exempt, I am ok with stamping it.

@chinmaygarde
Copy link
Member

Platform views that have their own view hierarchies that have their own animations may potentially be disrupted by this. If we wanted to disabled this just for our own views (including the overlays), I suggested overriding [CALayerDelegate actionForLayer:forKey] instead. This will make us do the right thing and stay our of the way of platform views depending on the transaction on top of the transaction stack.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants