[Impeller] fix unbalanced restores. #51648
Conversation
jonahwilliams
added
the
autosubmit
…145709) flutter/engine@ef896e9...04191a1 2024-03-25 [email protected] [Impeller] fix unbalanced restores. (flutter/engine#51648) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Might this fix be effective also for this error? [ERROR:flutter/impeller/base/validation.cc(49)] Break on 'ImpellerValidationBreak' to inspect point of failure: EntityPass (Depth=1) contains one or more clips with an unresolved depth value. |
|
I just discovered it and couldnt debug. It is printing non-stop when opening a stickers keyboard loading lottie animations. This is also a recent regression, we had no issue with that so far. |
Hey @delfme, I think that's a different issue. It's related to some clip changes we've been making. I didn't make this error message a crasher because it's normally recoverable, but it's a bit concerning that it's possible to hit this path. If you happen to have repro for this, could you toss it in a new bug and tag me? That would be super helpful. Thanks! |
3 participants
Fixes flutter/flutter#145528 by checking if the clip coverage stack is empty for restoring. Adds a protective empty check in clip replay.
I have a plan to pull the clip stack into something more testable to make this better, but opening this as a simpler fix first.