This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add more explicit logging (just to stderr) if a try-job detects an untriaged image
#51454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
added
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
Work towards flutter/flutter#145219. Combined with #51454, we should be more "sure" that (a) Skia Gold is getting every image we're uploading and (b) Flutter Gold is correctly flagging untriaged images. /cc @gaaclarke
5 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2024
…etects an untriaged image (flutter/engine#51454)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 15, 2024
…145237) flutter/engine@c2fd533...ba1115c 2024-03-15 [email protected] Add more explicit logging (just to `stderr`) if a try-job detects an untriaged image (flutter/engine#51454) 2024-03-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] A toolkit for managed handles to Android NDK vended objects. (#51334)" (flutter/engine#51457) 2024-03-15 [email protected] [Impeller] A toolkit for managed handles to Android NDK vended objects. (flutter/engine#51334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#145219.
Previously all logging would be silent in the case that
test_foouploads a digest that is considered "untriaged", and we'd be entirely reliant on theflutter-goldcheck to pick this up asynchronously.As part of debugging flutter/flutter#145219 (but probably to keep this code indefinitely, it's not harmful), we now unconditionally log the swallowed failures to
stderrso they will show up in our LUCI logs./cc @gaaclarke @jonahwilliams