Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ public class ExternalTextureFlutterActivity extends TestActivity {
private static final int SURFACE_WIDTH = 192;
private static final int SURFACE_HEIGHT = 256;

private SurfaceRenderer surfaceViewRenderer, flutterRenderer;
private SurfaceRenderer flutterRenderer;

// Latch used to ensure both SurfaceRenderers produce a frame before taking a screenshot.
private final CountDownLatch firstFrameLatch = new CountDownLatch(2);
private final CountDownLatch firstFrameLatch = new CountDownLatch(1);

private long textureId = 0;
private TextureRegistry.SurfaceProducer surfaceProducer;
Expand All @@ -62,7 +62,6 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {

String surfaceRenderer = getIntent().getStringExtra("surface_renderer");
assert surfaceRenderer != null;
surfaceViewRenderer = selectSurfaceRenderer(surfaceRenderer, getIntent().getExtras());
flutterRenderer = selectSurfaceRenderer(surfaceRenderer, getIntent().getExtras());

// Create and place a SurfaceView above the Flutter content.
Expand All @@ -86,7 +85,6 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {

SurfaceHolder surfaceHolder = surfaceView.getHolder();
surfaceHolder.setFixedSize(SURFACE_WIDTH, SURFACE_HEIGHT);
surfaceHolder.addCallback(new SurfaceRendererCallback(surfaceViewRenderer, firstFrameLatch));
}

@Override
Expand Down Expand Up @@ -137,7 +135,6 @@ private MediaExtractor createMediaExtractor() {

@Override
public void onPause() {
surfaceViewRenderer.destroy();
flutterRenderer.destroy();
surfaceProducer.release();
super.onPause();
Expand Down Expand Up @@ -461,27 +458,4 @@ private void destroyReaderWriter() {
handlerThread.quitSafely();
}
}

private static class SurfaceRendererCallback implements SurfaceHolder.Callback {
final SurfaceRenderer surfaceRenderer;
final CountDownLatch onFirstFrame;

public SurfaceRendererCallback(SurfaceRenderer surfaceRenderer, CountDownLatch onFirstFrame) {
this.surfaceRenderer = surfaceRenderer;
this.onFirstFrame = onFirstFrame;
}

@Override
public void surfaceCreated(@NonNull SurfaceHolder holder) {
surfaceRenderer.attach(holder.getSurface(), onFirstFrame);
}

@Override
public void surfaceChanged(@NonNull SurfaceHolder holder, int format, int width, int height) {
surfaceRenderer.repaint();
}

@Override
public void surfaceDestroyed(@NonNull SurfaceHolder holder) {}
}
}