Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add android_debug_unopt_arm64 to local_engine.json. #51427

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Add android_debug_unopt_arm64 to local_engine.json. #51427

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
432df4b
Add android_debug_unopt_arm64 to local_engine builders.
matanlurey Mar 14, 2024
fc41d69
++
matanlurey Mar 14, 2024
6cabde1
Revert.
matanlurey Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ci/builders/local_engine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,26 @@
"targets": []
}
},
{
"drone_dimensions": [
Copy link
Member

@zanderso zanderso Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope to get the builds in this file running on CI soon, so wondering if local workflows will need both the unopt and non-unopt version of android_debug_arm64?

Copy link
Contributor Author

@matanlurey matanlurey Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked offline, local builds will probably all be unopt (the other configurations will be covered by release builders), so I am going to remove android_debug_arm64 (/cc @johnmccutchan) from this file, and then continue to chat with John about "what should we do for duplicate names in general".

Copy link
Contributor

@johnmccutchan johnmccutchan Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only use android_debug_arm64 and never the unopt variant. So please don't remove it.

Copy link
Contributor Author

@matanlurey matanlurey Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only use android_debug_arm64 and never the unopt variant. So please don't remove it.

Ack. Can I clarify though, why is this builder not sufficient?

Copy link
Contributor Author

@matanlurey matanlurey Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted offline, because that builder doesn't run/allow macos. Reverted that - block.

"os=Mac-13",
"os=Linux"
],
"gn": [
"--runtime-mode",
"debug",
"--unoptimized",
"--android",
"--android-cpu=arm64",
"--no-stripped",
"--no-lto"
],
"name": "android_debug_unopt_arm64",
"ninja": {
"config": "android_debug_unopt_arm64",
"targets": []
}
},
{
"drone_dimensions": [
"os=Mac-13",
Expand Down