-
Notifications
You must be signed in to change notification settings - Fork 6k
[web] Split initialization of the _flutter namespace and loader object. #51294
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
There's several tests covering this gets initialized correctly; not sure if we have a way to test that this is initialized slightly differently though. |
eyebrowsoffire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
This is part of our test bootstrap here:
Unfortunately, I cannot add any code that runs before the bootstrap; my idea was to then run the rest of the test, but by the time the |
|
Another way is to have |
|
By tweaking the |
|
It seems my test to the platform isn't liked by some web tests? Wat? |
|
Reproduced locally, and found JS error in strict mode where my: So replaced the initialization to the exact same thing we use in flutter.js: That should do the trick. |
|
Created an issue while investigating this flutter/flutter#144969 |
…ions) (#145002) Manual roll requested by [email protected] flutter/engine@6cefbe1...6771307 2024-03-11 [email protected] [web] Split initialization of the _flutter namespace and loader object. (flutter/engine#51294) 2024-03-11 [email protected] Roll Dart SDK from 09a1a1ede1c4 to 7a2c94fd0a26 (1 revision) (flutter/engine#51338) 2024-03-11 [email protected] Roll Skia from 6f10903e2d28 to 32f1cb50734a (5 revisions) (flutter/engine#51331) 2024-03-11 [email protected] Make scenario app have translucent splash screen so it doesn't affect screenshot colors (flutter/engine#51329) 2024-03-11 [email protected] [gn] Change sdk_rewriter() template to use depfiles (flutter/engine#51314) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This makes it possible to more flexibly compose
{{flutter_js}}and{{flutter_build_options}}in @eyebrowsoffire's bootstrapping improvements PR.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.