This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Create a new render target with the specified attachment configs when reusing cached render target textures #51208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfigs when reusing cached render target textures If the RenderTargetCache::Create methods reuse a cached RenderTarget as is, then the returned RenderTarget may contain AttachmentConfig parameters that do not match the ones passed to the create method. This PR instead creates a new RenderTarget based on the existing textures from the cached RenderTarget.
| auto depth = render_target_data.render_target.GetDepthAttachment(); | ||
| return RenderTargetAllocator::CreateOffscreen( | ||
| context, size, mip_count, label, color_attachment_config, | ||
| stencil_attachment_config, color0.texture, depth->texture); |
Contributor
There was a problem hiding this comment.
This is getting flagged as unchecked optional usage, since depth may not be defined - but that should be OK if you default depth.texture to nullptr
jonahwilliams
approved these changes
Mar 5, 2024
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM (but not to CI)
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2024
…tachment configs when reusing cached render target textures (flutter/engine#51208)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 6, 2024
…144710) flutter/engine@20037e3...44405ae 2024-03-06 [email protected] [Impeller] Append fewer redundant points when bridging triangle strips between contours. (flutter/engine#51232) 2024-03-06 [email protected] [Impeller] Apply padding for alignment when doing HostBuffer::Emplace with a callback (flutter/engine#51221) 2024-03-06 [email protected] [Impeller] Create a new render target with the specified attachment configs when reusing cached render target textures (flutter/engine#51208) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the RenderTargetCache::Create methods reuse a cached RenderTarget as is, then the returned RenderTarget may contain AttachmentConfig parameters that do not match the ones passed to the create method.
This PR instead creates a new RenderTarget based on the existing textures from the cached RenderTarget.